[CELEBORN-2240] Adapt to SPARK-51756 which add a new parameter checksumValue in MapStatus.apply#3570
Closed
pan3793 wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-2240] Adapt to SPARK-51756 which add a new parameter checksumValue in MapStatus.apply#3570pan3793 wants to merge 1 commit intoapache:mainfrom
checksumValue in MapStatus.apply#3570pan3793 wants to merge 1 commit intoapache:mainfrom
Conversation
cxzl25
approved these changes
Dec 19, 2025
turboFei
approved these changes
Dec 19, 2025
turboFei
reviewed
Dec 19, 2025
|
|
||
| private static final DynMethods.BoundMethod MAP_STATUS_APPLY_METHOD = | ||
| DynMethods.builder("apply") | ||
| // for SPARK-51756 (4.1.0) and later |
Member
There was a problem hiding this comment.
SPARK-54663 or SPARK-51756
Member
There was a problem hiding this comment.
how about add the PR title as well, the new field is checksumValue.
Member
Author
There was a problem hiding this comment.
Okay, seems the author changes the JIRA ticket in the PR title after merging -
- the git commit history is SPARK-51756
- the final PR title is changed to SPARK-54663
not a big deal, since SPARK-54663 is a sub-task of SPARK-51756.
SteNicholas
approved these changes
Dec 20, 2025
RexXiong
approved these changes
Dec 20, 2025
pan3793
changed the title
checksumValue in MapStatus.apply
Member
Author
|
thanks, merged to main for 0.7.0 |
xy2953396112
pushed a commit
to xy2953396112/celeborn
that referenced
this pull request
Dec 25, 2025
…sumValue` in `MapStatus.apply` Adapt to SPARK-51756, which changes the MapStatus API used by Celeborn. A necessary step to make Celeborn support Spark 4.1. No. Yes, it makes Have integrated with Spark 4.1 in the internal test env, and verified by some simple queries. Closes apache#3570 from pan3793/CELEBORN-2240. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adapt to SPARK-51756, which changes the MapStatus API used by Celeborn.
Why are the changes needed?
A necessary step to make Celeborn support Spark 4.1.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
Yes, it makes
How was this patch tested?
Have integrated with Spark 4.1 in the internal test env, and verified by some simple queries.