Skip to content

Comments

Add pgvector doc#227

Merged
tuhaihe merged 6 commits intoapache:mainfrom
xtangcode:main
Jan 22, 2025
Merged

Add pgvector doc#227
tuhaihe merged 6 commits intoapache:mainfrom
xtangcode:main

Conversation

@xtangcode
Copy link
Contributor

Add pgvector doc to describe how to use pgvector search in cloudberry.

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Contributor's checklist

Here are some reminders before you submit your pull request:

Add pgvector doc to describe how to use pgvector search in cloudberry.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiiii, @xtangcode welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!

@xtangcode xtangcode requested a review from tuhaihe January 22, 2025 03:43
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! These are very minor comments on format. PTAL

In addition, to make this new document searchable on the site's left navigation menu, please also update https://github.com/apache/cloudberry-site/blob/main/sidebars.ts#L69 by adding the file name pgvector-search to this line.

Copy link
Member

@tuhaihe tuhaihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can add the doc item to the file sidebars.ts for a better index. Thanks!

xtangcode and others added 3 commits January 22, 2025 12:53
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Add pgvector doc to sidebar for better indexing.
@xtangcode
Copy link
Contributor Author

Also, can add the doc item to the file sidebars.ts for a better index. Thanks!

added.

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alwin Tang added 2 commits January 22, 2025 14:15
Added notes to point out that pgvector is not an official feature yet.
@tuhaihe tuhaihe merged commit 87566fd into apache:main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants