-
Notifications
You must be signed in to change notification settings - Fork 196
CI: update the must passed jobs' name in .asf.yaml #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ee82a0 to
37efa4f
Compare
|
Can see the checks are set as required, except:
The results are the same as the original set, like the checks in #1171 |
8e9ac9f to
03529de
Compare
03529de to
24d5131
Compare
leborchuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me, job-id we use
``
xifos@localhost$ grep "Job:" .github/workflows/build-cloudberry.yml
Job: check-skip
Job: prepare-test-matrix
Job: build
Job: rpm-install-test
Job: test
Job: report
``
I also checked - the actual IDs are the same as in description
For the contexts, should be the names of checks that must pass, which are the jobs' `name` property, instead of the steps' id value.
24d5131 to
de6c197
Compare
edespino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
This PR correctly updates the required status checks in .asf.yaml to use job IDs instead of job display names.
Key Changes Verified:
- ✅ Changed from display names (
Build Apache Cloudberry RPM,RPM Install Test Apache Cloudberry, etc.) to job IDs (build,rpm-install-test, etc.) - ✅ Simplified matrix job checks - using parent job ID
testinstead of listing all matrix combinations individually - ✅ All job IDs match the actual job definitions in
.github/workflows/build-cloudberry.yml:check-skip(line 164)prepare-test-matrix(line 207)build(line 413)rpm-install-test(line 693)test(line 876)report(line 1742)
Testing Notes:
Validated the workflow trigger behavior and confirmed that GitHub's branch protection matches status checks by job ID (the YAML key under jobs:), not by the optional name: field. This change ensures branch protection will correctly wait for the required checks before allowing merge.
The simplified approach is more maintainable and aligns with GitHub Actions best practices.
Technical Background:
GitHub matches required status checks using job IDs from workflow files, not the display names. When multiple workflows have jobs with the same ID (e.g., both build-cloudberry.yml and build-dbg-cloudberry.yml have a build job), GitHub will wait for all matching jobs to complete. This PR correctly identifies the job IDs that should be required for PRs to main.
For the contexts, should be the names of checks that must pass, which are the jobs'
nameproperty, instead of the steps' id value.Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions