Skip to content

ORCA: use backtrace replace the foreach nested foreach #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
my-ship-it merged 1 commit into from
Aug 1, 2025
Merged

ORCA: use backtrace replace the foreach nested foreach #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/backend/gporca/libgpopt/include/gpopt/operators/CPhysical.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ class CPhysical : public COperator
// total number of optimization requests
ULONG m_ulTotalOptRequests;

// use back trace generate the opt requires
void BackTraceOptRequests(UlongPtrArray *pdrgpulpOptReqsExpanded,
const ULONG *ulOptReqs, ULONG ulOptReqsSize,
ULONG_PTR *current, ULONG cursz);

// update number of requests of a given property
void UpdateOptRequests(ULONG ulPropIndex, ULONG ulRequests);

Expand Down
63 changes: 36 additions & 27 deletions src/backend/gporca/libgpopt/src/operators/CPhysical.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,35 @@ CPhysical::CPhysical(CMemoryPool *mp)
}


//---------------------------------------------------------------------------
// @function:
// CPhysical::BackTraceOptRequests
//
// @doc:
// Use back trace to generated the
//
//---------------------------------------------------------------------------
void
CPhysical::BackTraceOptRequests(UlongPtrArray *pdrgpulpOptReqsExpanded,
const ULONG *ulOptReqs, ULONG ulOptReqsSize,
ULONG_PTR *current, ULONG cursz)
{
if (cursz == ulOptReqsSize)
{
ULONG_PTR *copyOne = GPOS_NEW_ARRAY(m_mp, ULONG_PTR, GPOPT_PLAN_PROPS);
clib::Memcpy(copyOne, current, GPOPT_PLAN_PROPS * sizeof(ULONG_PTR));
pdrgpulpOptReqsExpanded->Append(copyOne);
return;
}

for (ULONG i = 0; i < ulOptReqs[cursz]; i++)
{
current[cursz] = i;
BackTraceOptRequests(pdrgpulpOptReqsExpanded, ulOptReqs, ulOptReqsSize,
current, cursz + 1);
}
}

//---------------------------------------------------------------------------
// @function:
// CPhysical::UpdateOptRequests
Expand Down Expand Up @@ -88,37 +117,17 @@ CPhysical::UpdateOptRequests(ULONG ulPropIndex, ULONG ulRequests)
m_ulTotalOptRequests = ulOptReqs;

// update expanded requests
const ULONG ulOrderRequests = UlOrderRequests();
const ULONG ulDistrRequests = UlDistrRequests();
const ULONG ulRewindRequests = UlRewindRequests();
const ULONG ulPartPropagateRequests = UlPartPropagateRequests();
ULONG ulaOptReqs[GPOPT_PLAN_PROPS] = {UlOrderRequests(), UlDistrRequests(),
UlRewindRequests(),
UlPartPropagateRequests()};

CRefCount::SafeRelease(m_pdrgpulpOptReqsExpanded);
m_pdrgpulpOptReqsExpanded = nullptr;
m_pdrgpulpOptReqsExpanded = GPOS_NEW(m_mp) UlongPtrArray(m_mp);
for (ULONG ulOrder = 0; ulOrder < ulOrderRequests; ulOrder++)
{
for (ULONG ulDistr = 0; ulDistr < ulDistrRequests; ulDistr++)
{
for (ULONG ulRewind = 0; ulRewind < ulRewindRequests; ulRewind++)
{
for (ULONG ulPartPropagate = 0;
ulPartPropagate < ulPartPropagateRequests;
ulPartPropagate++)
{
ULONG_PTR *pulpRequest =
GPOS_NEW_ARRAY(m_mp, ULONG_PTR, GPOPT_PLAN_PROPS);

pulpRequest[0] = ulOrder;
pulpRequest[1] = ulDistr;
pulpRequest[2] = ulRewind;
pulpRequest[3] = ulPartPropagate;

m_pdrgpulpOptReqsExpanded->Append(pulpRequest);
}
}
}
}
ULONG_PTR *pulpRequest = GPOS_NEW_ARRAY(m_mp, ULONG_PTR, GPOPT_PLAN_PROPS);
BackTraceOptRequests(m_pdrgpulpOptReqsExpanded, ulaOptReqs,
GPOPT_PLAN_PROPS, pulpRequest, 0);
GPOS_DELETE_ARRAY(pulpRequest);
}


Expand Down
Loading