Fix invalid attribute mapping when runtime filter pushdown is enabled.#1233
Merged
my-ship-it merged 1 commit intoapache:mainfrom Aug 1, 2025
Merged
Fix invalid attribute mapping when runtime filter pushdown is enabled.#1233my-ship-it merged 1 commit intoapache:mainfrom
my-ship-it merged 1 commit intoapache:mainfrom
Conversation
Member
|
test this by tpc-ds ? |
Contributor
Author
tested on the TPC-DS 1TB dataset |
yjhjstz
approved these changes
Jul 17, 2025
my-ship-it
force-pushed
the
main
branch
6 times, most recently
from
c20580f to
c114dcc
Compare
my-ship-it
force-pushed
the
main
branch
3 times, most recently
from
56d2f47 to
c9c4da5
Compare
Seqscan is a special case, it's targetlist is a projection of the relation's attributes, so we need to find the attribute number of the column in the relation. While TargetEntry::resno is just the attribute number for dynamic seqscan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seqscan is a special case, it's targetlist is a projection of the relation's attributes, so we need to find the attribute number of the column in the relation.
While TargetEntry::resno is just the attribute number for dynamic seqscan.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions