ORCA: create windows hash aggregation physical operator when vectorization enabled #1258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqizho
changed the title
jiaqizho
commented
Jul 25, 2025
jiaqizho
force-pushed
the
orca-support-hash-windowagg
branch
3 times, most recently
from
4714e80 to
3c9d812
Compare
Contributor
|
Is it better to add |
Contributor
|
Is it better to add code below in explain.c? |
1 similar comment
Contributor
|
Is it better to add code below in explain.c? |
jiaqizho
force-pushed
the
orca-support-hash-windowagg
branch
from
3c9d812 to
8374618
Compare
Contributor
Author
no need, cause the the row executor won't get the |
jiaqizho
force-pushed
the
orca-support-hash-windowagg
branch
from
8374618 to
4856e06
Compare
jiaqizho
changed the title
jiaqizho
force-pushed
the
orca-support-hash-windowagg
branch
from
4856e06 to
3ad1cd4
Compare
my-ship-it
reviewed
Aug 14, 2025
my-ship-it
approved these changes
Aug 14, 2025
Contributor
my-ship-it
left a comment
my-ship-it
left a comment
There was a problem hiding this comment.
LGTM in general except one comment
jiaqizho
force-pushed
the
orca-support-hash-windowagg
branch
from
3ad1cd4 to
2ac1f69
Compare
gongxun0928
approved these changes
Aug 14, 2025
jiaqizho
force-pushed
the
orca-support-hash-windowagg
branch
from
2ac1f69 to
1b1675c
Compare
…xector In this PR, ORCA now supports generating `WindowHashAgg` plans which already have implementation in the vectorization executor. However, the CBDB row executor currently lacks implementation for the WindowHashAgg operator. To prevent ORCA from generating this operator in the row executor, I've added an struct which named `OptimizerOptions` to control the plan for row executor or vectorization executor. (By the way, ORCA may later generate plans specifically for the vectorization executor). The `WindowAgg` operator implemention in the vectorization execution is: 1. First, sorting the input rows by `ORDER BY` keys 2. Then do the `PARTITION` by `PARTITION BY` keys 3. Finally do the window function. Since step1 must be globally sorted, it cannot be parallelized in the vectorization executor. This results in poor performance of the `WindowAgg` operator. By contrast, `WindowHashAgg` employs a more efficient approach: 1. First hashes input data into buckets based on `PARTITION BY` keys 2. Then sorts data `within each bucket` according to `ORDER BY` keys 3. Finally computes window functions on the sorted bucket data For the row engine, `WindowHashAgg` operators will not be generated. Also current commit introduces a new GUC named `optimizer_force_window_hash_agg` to force generate plans with `WindowHashAgg` (Don't used this GUC expect debug ORCA). Co-Author-By: zhangyue <[email protected]>
jiaqizho
force-pushed
the
orca-support-hash-windowagg
branch
from
1b1675c to
e9a0f5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions