Skip to content

Fix some flaky test cases #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
my-ship-it merged 1 commit into from
Aug 1, 2025
Merged

Fix some flaky test cases #1272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/test/isolation2/isolation2_schedule
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,10 @@ test: reindex/reindextable_while_altertable_ao_part_btree reindex/reindextable_w
# upstream also has this issue, so disable them for now
# test: reindex/reindextable_while_dropindex_ao_part_btree reindex/reindextable_while_dropindex_heap_part_btree reindex/reindextable_while_dropindex_aoco_part_btree

test: reindex/reindextable_while_reindex_idx_ao_part_btree reindex/reindextable_while_reindex_idx_heap_part_btree reindex/reindextable_while_reindex_idx_aoco_part_btree
test: reindex/reindextable_while_reindex_idx_ao_bitmap reindex/reindextable_while_reindex_idx_heap_bitmap reindex/reindextable_while_reindex_idx_aoco_bitmap
# flaky tests: the tests prefixed with "reindextable_while_reindex_idx" may failed, and the reason of failed is not related to MVCC.
ignore: reindex/reindextable_while_reindex_idx_ao_part_btree reindex/reindextable_while_reindex_idx_heap_part_btree reindex/reindextable_while_reindex_idx_aoco_part_btree
ignore: reindex/reindextable_while_reindex_idx_ao_bitmap reindex/reindextable_while_reindex_idx_heap_bitmap reindex/reindextable_while_reindex_idx_aoco_bitmap

test: reindex/serializable_reindex_with_drop_column_heap
test: reindex/serializable_reindex_with_drop_index_ao reindex/serializable_reindex_with_drop_index_heap
test: reindex/repeatable_read_reindex_with_insert_heap
Expand Down
4 changes: 4 additions & 0 deletions src/test/regress/expected/aggregates.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3264,6 +3264,8 @@ drop table agg_hash_3;
drop table agg_hash_4;
-- GitHub issue https://github.com/greenplum-db/gpdb/issues/12061
-- numsegments of the general locus should be -1 on create_minmaxagg_path
set enable_indexscan = off;
set enable_indexonlyscan = off;
explain analyze select count(*) from pg_class, (select count(*) > 0 from (select count(*) from pg_class where relnatts > 8) x) y;
QUERY PLAN
-----------------------------------------------------------------------------------------------------------------------
Expand All @@ -3279,6 +3281,8 @@ explain analyze select count(*) from pg_class, (select count(*) > 0 from (select
Execution Time: 0.302 ms
(10 rows)

reset enable_indexscan;
reset enable_indexonlyscan;
-- test aggno
create table tgb1(v1 int, v2 int, v3 int);
NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'v1' as the Apache Cloudberry data distribution key for this table.
Expand Down
4 changes: 4 additions & 0 deletions src/test/regress/expected/aggregates_optimizer.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3430,6 +3430,8 @@ drop table agg_hash_3;
drop table agg_hash_4;
-- GitHub issue https://github.com/greenplum-db/gpdb/issues/12061
-- numsegments of the general locus should be -1 on create_minmaxagg_path
set enable_indexscan = off;
set enable_indexonlyscan = off;
explain analyze select count(*) from pg_class, (select count(*) > 0 from (select count(*) from pg_class where relnatts > 8) x) y;
INFO: GPORCA failed to produce a plan, falling back to Postgres-based planner
DETAIL: Falling back to Postgres-based planner because GPORCA does not support the following feature: Queries on master-only tables
Expand All @@ -3448,6 +3450,8 @@ DETAIL: Falling back to Postgres-based planner because GPORCA does not support
Execution Time: 0.198 ms
(11 rows)

reset enable_indexscan;
reset enable_indexonlyscan;
-- test aggno
create table tgb1(v1 int, v2 int, v3 int);
NOTICE: Table doesn't have 'DISTRIBUTED BY' clause -- Using column named 'v1' as the Apache Cloudberry data distribution key for this table.
Expand Down
4 changes: 4 additions & 0 deletions src/test/regress/sql/aggregates.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,7 +1446,11 @@ drop table agg_hash_4;

-- GitHub issue https://github.com/greenplum-db/gpdb/issues/12061
-- numsegments of the general locus should be -1 on create_minmaxagg_path
set enable_indexscan = off;
set enable_indexonlyscan = off;
explain analyze select count(*) from pg_class, (select count(*) > 0 from (select count(*) from pg_class where relnatts > 8) x) y;
reset enable_indexscan;
reset enable_indexonlyscan;

-- test aggno
create table tgb1(v1 int, v2 int, v3 int);
Expand Down
Loading