Replace pip3 download with curl for Python deps#1283
Merged
tuhaihe merged 1 commit intoapache:mainfrom Aug 6, 2025
Merged
Conversation
Member
Author
|
|
2f15c6b to
09851d4
Compare
Member
Author
|
Updates: will add the curl, pip3 check in the configure.ac. Why?
Why use curl instead of
|
a5b64d0 to
96f4788
Compare
Member
Author
|
Already tested successfully on Ubuntu 20.04/22.04 + Rocky Linux 8/9. |
Member
Author
|
Note This commit will also be cherry-picked into the branch |
jiaqizho
reviewed
Aug 5, 2025
Replace pip3 download commands with curl for downloading psutil, PyYAML, PyGreSQL and mock packages in gpMgmt/bin/Makefile. This change unifies the download mechanism to use curl consistently for all Python dependencies, avoiding potential pip3 download compatibility issues across different environments. Changes: - Remove pip3 download commands for psutil, PyYAML, PyGreSQL & mock - Use curl to download packages directly from PyPI - Maintain existing wheel and cython installation for PyYAML build - Keep the same package versions and download locations Also, add curl and pip3 dependency detection in configure.ac file for better user experience. When `--with-pythonsrc-ext` option is enabled, configure can check the required dependencies early.
xtangcode
approved these changes
Aug 6, 2025
xtangcode
left a comment
There was a problem hiding this comment.
Configure updates to support deps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace pip3 download commands with curl for downloading psutil,
PyYAML and PyGreSQL packages in gpMgmt/bin/Makefile.
This change unifies the download mechanism to use curl consistently
for all Python dependencies, avoiding potential pip3 download
compatibility issues across different environments.
Changes:
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions