Align scan terminology: Shared Scan and ShareInputScan. #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avamingli
force-pushed
the
share_input_scan
branch
from
a7ace17 to
6dfc433
Compare
gongxun0928
approved these changes
Aug 20, 2025
The plan node appears as 'Shared Scan' in user's EXPLAIN output, while internally it's represented as ShareInputScan type. Most codes use the correct terms, but some places incorrectly mix: - 'shared input scan' in codebase (should be 'ShareInputScan') - 'Share Scan' in EXPLAIN (should be 'Shared Scan') This change aligns all usage while preserving existing correct references. Authored-by: Zhang Mingli [email protected]
avamingli
force-pushed
the
share_input_scan
branch
from
6dfc433 to
05b41c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan node appears as 'Shared Scan' in user's EXPLAIN output, while internally it's represented as ShareInputScan type.
Most codes use the correct terms, but some places incorrectly mix:
This change aligns all usage while preserving existing correct references.
Authored-by: Zhang Mingli [email protected]
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions