Fix and rename --use-unique-keys option and add TAP test#1508
Merged
Conversation
Cloudberry has --use-unique-keys options since cc797b9. However, it does not work, at least at current HEAD. Fix that, and also rename option, to better indicate its use case. If user does NOT use this option, pgbenc will create unique index. If use does use this option, pgbench will not. So, rename to --use-non-unique-keys. Found during PG16 kernel rebase.
my-ship-it
approved these changes
Dec 25, 2025
x4m
approved these changes
Dec 25, 2025
leborchuk
approved these changes
Dec 25, 2025
yjhjstz
pushed a commit
to yjhjstz/cloudberry
that referenced
this pull request
Jan 9, 2026
* Fix and rename --use-unique-keys option and add TAP test Cloudberry has --use-unique-keys options since cc797b9. However, it does not work, at least at current HEAD. Fix that, and also rename option, to better indicate its use case. If user does NOT use this option, pgbenc will create unique index. If use does use this option, pgbench will not. So, rename to --use-non-unique-keys. Found during PG16 kernel rebase. * Update 001_pgbench_with_server.pl (cherry picked from commit 8bde32c)
hw118118
pushed a commit
to hw118118/cloudberrydb
that referenced
this pull request
Jan 27, 2026
* Fix and rename --use-unique-keys option and add TAP test Cloudberry has --use-unique-keys options since cc797b9. However, it does not work, at least at current HEAD. Fix that, and also rename option, to better indicate its use case. If user does NOT use this option, pgbenc will create unique index. If use does use this option, pgbench will not. So, rename to --use-non-unique-keys. Found during PG16 kernel rebase. * Update 001_pgbench_with_server.pl
hw118118
pushed a commit
to hw118118/cloudberrydb
that referenced
this pull request
Jan 27, 2026
* Fix and rename --use-unique-keys option and add TAP test Cloudberry has --use-unique-keys options since cc797b9. However, it does not work, at least at current HEAD. Fix that, and also rename option, to better indicate its use case. If user does NOT use this option, pgbenc will create unique index. If use does use this option, pgbench will not. So, rename to --use-non-unique-keys. Found during PG16 kernel rebase. * Update 001_pgbench_with_server.pl
hw118118
pushed a commit
to hw118118/cloudberrydb
that referenced
this pull request
Jan 28, 2026
* Fix and rename --use-unique-keys option and add TAP test Cloudberry has --use-unique-keys options since cc797b9. However, it does not work, at least at current HEAD. Fix that, and also rename option, to better indicate its use case. If user does NOT use this option, pgbenc will create unique index. If use does use this option, pgbench will not. So, rename to --use-non-unique-keys. Found during PG16 kernel rebase. * Update 001_pgbench_with_server.pl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudberry has --use-unique-keys options since cc797b9. However, it does not work, at least at current HEAD. That is, specifying --use-unique-keys to pgbench leads to fatal error, because option in not recognized. Fix that, and also rename option, to better indicate its use case. If user does NOT use this option, pgbench will create unique index. If user does use this option, pgbench will not. So, rename to --use-non-unique-keys.
Found during PG16 kernel rebase.