Skip to content

ORCA: Fix memory leak in CWindowOids by adding destructor #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yjhjstz wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

ORCA: Fix memory leak in CWindowOids by adding destructor #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f06c0
ORCA: Fix memory leak in CWindowOids by adding destructor
yjhjstz Jan 15, 2026
ff17a28
Update src/backend/gporca/libgpopt/src/base/CWindowOids.cpp
yjhjstz Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/backend/gporca/libgpopt/include/gpopt/base/CWindowOids.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ class CWindowOids : public CRefCount
CWindowOids(CMemoryPool *mp, OID row_number_oid, OID rank_oid,
OID dense_rank_oid);

~CWindowOids() override;

// accessor of oid value of "row_number" function
OID OidRowNumber() const;
IMDId *MDIdRowNumber() const;
Expand Down
7 changes: 7 additions & 0 deletions src/backend/gporca/libgpopt/src/base/CWindowOids.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@ CWindowOids::CWindowOids(CMemoryPool *mp, OID row_number_oid, OID rank_oid,
m_MDDenseRank = GPOS_NEW(mp) CMDIdGPDB(IMDId::EmdidGeneral, m_oidDenseRank);
}

CWindowOids::~CWindowOids()
{
CRefCount::SafeRelease(m_MDIdRowNumber);
CRefCount::SafeRelease(m_MDIdRank);
CRefCount::SafeRelease(m_MDDenseRank);
}

OID
CWindowOids::OidRowNumber() const
{
Expand Down
Loading