Skip to content

autocomplete: allow completion based on name/detail of exisiting results for parameter #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

autocomplete: allow completion based on name/detail of exisiting results for parameter #165

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22a3ae0
autocomplete: allow completion based on name/detail
shwstppr Jul 31, 2025
c2dde22
Merge remote-tracking branch 'origin/main' into name-autocompleter
shwstppr Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cli/completer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ func (t *autoCompleter) Do(line []rune, pos int) (options [][]rune, offset int)
return argOptions[i].Value < argOptions[j].Value
})
for _, item := range argOptions {
if strings.HasPrefix(item.Value, argInput) {
if strings.HasPrefix(item.Value, argInput) || (len(item.Detail) > 0 && strings.HasPrefix(item.Detail, argInput)) {
filteredOptions = append(filteredOptions, item)
}
}
Expand All @@ -421,12 +421,14 @@ func (t *autoCompleter) Do(line []rune, pos int) (options [][]rune, offset int)
}
for _, item := range filteredOptions {
option := item.Value + " "
if len(filteredOptions) > 1 && len(item.Detail) > 0 {
if len(filteredOptions) > 0 && len(item.Detail) > 0 {
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The condition change from > 1 to > 0 means details will now always be shown when they exist, even for single options. This could clutter the display unnecessarily. Consider if this change aligns with the intended UX behavior.

Suggested change
if len(filteredOptions) > 0 && len(item.Detail) > 0 {
if len(filteredOptions) > 1 && len(item.Detail) > 0 {

Copilot uses AI. Check for mistakes.
option += fmt.Sprintf("(%v)", item.Detail)
}
if strings.HasPrefix(option, argInput) {
options = append(options, []rune(option[len(argInput):]))
offset = len(argInput)
} else if len(item.Detail) > 0 && strings.HasPrefix(item.Detail, argInput) {
options = append(options, []rune(option))
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When matching on detail, the full option string is returned without adjusting the offset. This means the completion will include the entire option text, potentially overwriting the user's input. The offset should be set to 0 when returning the full option.

Suggested change
options = append(options, []rune(option))
options = append(options, []rune(option))
offset = 0

Copilot uses AI. Check for mistakes.
}
}
return
Expand Down
23 changes: 19 additions & 4 deletions vendor/github.com/chzyer/readline/complete.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.