Skip to content

config: prevent empty values for required configs #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

config: prevent empty values for required configs #176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f05fc9a
config: prevent empty values for required configs
shwstppr Aug 7, 2025
414b1ab
fix
shwstppr Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ const (
DEFAULT = "default"
)

var nonEmptyConfigKeys = map[string]bool{
"output": true,
"timeout": true,
"profile": true,
"url": true,
}

// DefaultACSAPIEndpoint is the default API endpoint for CloudStack.
const DefaultACSAPIEndpoint = "http://localhost:8080/client/api"

Expand Down Expand Up @@ -347,6 +354,10 @@ func (c *Config) LoadProfile(name string) {

// UpdateConfig updates and saves config
func (c *Config) UpdateConfig(key string, value string, update bool) {
if nonEmptyConfigKeys[key] && value == "" {
fmt.Printf("Error: value for '%s' must not be empty\n", key)
return
}
switch key {
case "prompt":
c.Core.Prompt = value
Expand Down