Skip to content

github-action: add ci workflow #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Aug 11, 2025

Runs some test using latest apache/cloudstack release as simulator MS.

Copy link

github-actions bot commented Aug 11, 2025

✅ Build complete for PR #180.

🔗 Download the cmk binaries (expires on August 21, 2025)

@rohityadavcloud rohityadavcloud added this to the 6.5.0 milestone Aug 11, 2025
Runs some test using latest apache/cloudstack release as simulator MS.

Signed-off-by: Abhishek Kumar <[email protected]>
@shwstppr shwstppr marked this pull request as ready for review August 11, 2025 11:11
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, I just wonder if we should invest in creating the zone with cmk as well and leave marvin out of the picture completely.

@shwstppr
Copy link
Contributor Author

clgtm, I just wonder if we should invest in creating the zone with cmk as well and leave marvin out of the picture completely.

I would not want to do that at the moment for the following reasons:

  • If, for some reason zone deployment fails (say due to wrong cmk call) then actual tests won't run
  • It would need additional effort, which may or may not be useful other than running this workflow

@DaanHoogland
Copy link
Contributor

clgtm, I just wonder if we should invest in creating the zone with cmk as well and leave marvin out of the picture completely.

I would not want to do that at the moment for the following reasons:

  • If, for some reason zone deployment fails (say due to wrong cmk call) then actual tests won't run
  • It would need additional effort, which may or may not be useful other than running this workflow

not for this version for sure, but if create zone fails it is good to know (that cmk is broken)

@DaanHoogland DaanHoogland merged commit ec71a4d into apache:main Aug 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants