Skip to content

autocomplete: allow searching configuration name #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
Merged

autocomplete: allow searching configuration name #184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f24c66
autocomplete: allow searching configuration name
shwstppr Aug 22, 2025
09e8b60
change
shwstppr Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions cli/completer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ import (
"github.com/apache/cloudstack-cloudmonkey/config"
)

var nameSupportingApis = []string{
"configuration",
}

func buildAPICacheMap(apiMap map[string][]*config.API) map[string][]*config.API {
for _, cmd := range cmd.AllCommands() {
verb := cmd.Name
Expand Down Expand Up @@ -232,14 +236,25 @@ func findAutocompleteAPI(arg *config.APIArg, apiFound *config.API, apiMap map[st
default:
// Heuristic: autocomplete for the arg for which a list<Arg without id/ids>s API exists
// For example, for zoneid arg, listZones API exists
cutIdx := len(argName)
base := argName
if strings.HasSuffix(argName, "id") {
cutIdx -= 2
base = strings.TrimSuffix(argName, "id")
} else if strings.HasSuffix(argName, "ids") {
cutIdx -= 3
base = strings.TrimSuffix(argName, "ids")
} else if argName == "name" {
for _, noun := range nameSupportingApis {
if strings.HasPrefix(apiFound.Noun, noun) {
base = noun
break
}
}
}
// Handle common cases where base ends with a vowel and needs "es"
if strings.HasSuffix(base, "s") || strings.HasSuffix(base, "x") || strings.HasSuffix(base, "z") || strings.HasSuffix(base, "ch") || strings.HasSuffix(base, "sh") {
relatedNoun = base + "es"
} else {
relatedNoun = base + "s"
}
relatedNoun = argName[:cutIdx] + "s"
}

config.Debug("Possible related noun for the arg: ", relatedNoun, " and type: ", arg.Type)
Expand Down