Skip to content

Add acl_id parameter to the example usage of the cloudstack_private_gateway resource #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bernardodemarco
Copy link
Member

The example usage of the cloudstack_private_gateway resource lacks the required acl_id parameter. This PR adds the required parameter to the example usage.

@DaanHoogland
Copy link
Contributor

nothing to do with this PR especially, but I noticed there is no license in the file and no error pertaining to that is reported. Is there an exclusion somewhere or do we need to install some?

@bernardodemarco
Copy link
Member Author

nothing to do with this PR especially, but I noticed there is no license in the file and no error pertaining to that is reported.

@DaanHoogland, yes

Is there an exclusion somewhere or do we need to install some?

Could this be an issue related with markdown files? The https://github.com/apache/cloudstack/blob/main/INSTALL.md file, for instance, does not have a license as well

@kiranchavala kiranchavala added this to the v0.6.0 milestone Aug 8, 2025
@DaanHoogland
Copy link
Contributor

nothing to do with this PR especially, but I noticed there is no license in the file and no error pertaining to that is reported.

Is there an exclusion somewhere or do we need to install some?

Could this be an issue related with markdown files? The https://github.com/apache/cloudstack/blob/main/INSTALL.md file, for instance, does not have a license as well

@bernardodemarco , as a project we are obliged (by ASF) to make sure all files contain a license header. In the main repo there is a maven task for that and the main pom.xml contains the exclusion list. It is our responsibility to maintain that list to only contain reasonable exclusions. RAT will check for apache and apache compatible licenses. I am trying to get the cli version to work but can’t get the exclusions to work yet. (needs more time/work)

Markdown files are not excluded by default, nor is any other type of file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants