serviceoffering: add params for custom offering, storage tags, encryptroot #212
Conversation
encryptroot Fixes apache#182 Adds params for Custom offerings. Constrained custom offerings allow min/max values for CPU and memory. Also adds params for encrypt root and storage tags. New params added, - customized - min_cpu_number - max_cpu_number - min_memory - max_memory - encrypt_root - storage_tags Signed-off-by: Abhishek Kumar <[email protected]>
shwstppr
force-pushed
the
add-serviceoff-params
branch
from
b40e651 to
9408600
Compare
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Adds support for custom service offerings in CloudStack by implementing parameters for constrained custom offerings, root disk encryption, and storage tags.
- Adds custom offering parameters (customized flag, min/max CPU/memory constraints)
- Implements root disk encryption capability for service offerings
- Adds storage tags support for service offering configuration
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| website/docs/r/service_offering.html.markdown | Documents the new parameters for custom offerings, encryption, and storage tags |
| cloudstack/resource_cloudstack_service_offering_test.go | Adds comprehensive test case for all new custom offering parameters |
| cloudstack/resource_cloudstack_service_offering.go | Implements the new schema fields and CRUD operations for custom offerings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@shwstppr Acceptance tests are failing. Please check. |
Signed-off-by: Abhishek Kumar <[email protected]>
There was a problem hiding this comment.
lgtm. works as expected. Some weird behavior when customized is set to false but other parameters like min_cpu_number & max_cpu_number are present. It will probably be a good improvement to ensure customized is set to true when other params are present.
Another failure is during update of storage tags only. Because of issue in the MS, the update fails when only storage tags are updated. But subsequent apply works fine.
|
@vishesh92 @shwstppr I see this service offering changes were merged, but why are we not moving forward with this? It has some significant changes in it , and the new way of creating these resources going forward |
Fixes #182
Adds params for Custom offerings. Constrained custom offerings allow min/max values for CPU and memory. Also adds params for encrypt root and storage tags.
New params added,