Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Dec 4, 2024

Description

This PR moves code intended for the 4.19.1 to 4.19.2 upgrade to the right path.

see #9759 (comment)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

it should be in 4.20.0->4.20.1 sql as well

@DaanHoogland
Copy link
Contributor Author

code lgtm

it should be in 4.20.0->4.20.1 sql as well

is in a different PR!

@weizhouapache
Copy link
Member

code lgtm
it should be in 4.20.0->4.20.1 sql as well

is in a different PR!

yes !
a PR for 4.20 branch

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (ef1a58d) to head (4392fce).
Report is 3 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10035      +/-   ##
============================================
+ Coverage     15.12%   15.14%   +0.02%     
- Complexity    11255    11279      +24     
============================================
  Files          5408     5408              
  Lines        473838   474327     +489     
  Branches      57770    57991     +221     
============================================
+ Hits          71676    71850     +174     
- Misses       394165   394464     +299     
- Partials       7997     8013      +16     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.86% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor Author

in #10036 (for reference)

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@BryanMLima BryanMLima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

@weizhouapache
Copy link
Member

CI failure is not related. fixed by #10037

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11712

@DaanHoogland DaanHoogland merged commit 762d549 into 4.19 Dec 4, 2024
47 of 50 checks passed
@DaanHoogland DaanHoogland deleted the pr9759-followup branch December 4, 2024 13:28
DaanHoogland added a commit that referenced this pull request Dec 4, 2024
* 4.19:
  move sql code to the right file (#10035)
DaanHoogland added a commit that referenced this pull request Dec 4, 2024
* 4.20:
  move sql code to the right file (#10035)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
* 4.19:
  move sql code to the right file (apache#10035)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
* 4.20:
  move sql code to the right file (apache#10035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants