-
Notifications
You must be signed in to change notification settings - Fork 1.2k
move sql code to the right file #10035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
it should be in 4.20.0->4.20.1 sql as well
is in a different PR! |
yes ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10035 +/- ##
============================================
+ Coverage 15.12% 15.14% +0.02%
- Complexity 11255 11279 +24
============================================
Files 5408 5408
Lines 473838 474327 +489
Branches 57770 57991 +221
============================================
+ Hits 71676 71850 +174
- Misses 394165 394464 +299
- Partials 7997 8013 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
in #10036 (for reference) |
engine/schema/src/main/resources/META-INF/db/schema-41910to41920.sql
Outdated
Show resolved
Hide resolved
…20.sql Co-authored-by: Fabricio Duarte <[email protected]>
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
BryanMLima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM
|
|
CI failure is not related. fixed by #10037 |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11712 |
* 4.19: move sql code to the right file (#10035)
* 4.20: move sql code to the right file (#10035)
Co-authored-by: Fabricio Duarte <[email protected]>
* 4.19: move sql code to the right file (apache#10035)
* 4.20: move sql code to the right file (apache#10035)



Description
This PR moves code intended for the 4.19.1 to 4.19.2 upgrade to the right path.
see #9759 (comment)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?