packaging: have noarch defined for rpms by yadvr · Pull Request #10057 · apache/cloudstack

yadvr · 2024-12-07T10:31:05Z

This makes rpms arch-independent. CloudStack rpms are largely arch independent. While deb pkgs are usable across archs now, rpms aren’t.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

This makes rpms arch-independent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr · 2024-12-07T10:32:09Z

@blueorangutan package

blueorangutan · 2024-12-07T10:34:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-12-07T10:38:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.98%. Comparing base (5167c3b) to head (5a57a1c).
Report is 1 commits behind head on 4.20.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10057      +/-   ##
============================================
+ Coverage     16.13%   16.98%   +0.84%     
- Complexity    12971    12972       +1     
============================================
  Files          5639     5245     -394     
  Lines        494297   461951   -32346     
  Branches      59908    54194    -5714     
============================================
- Hits          79774    78474    -1300     
+ Misses       405698   374800   -30898     
+ Partials       8825     8677     -148

Flag	Coverage Δ
uitests	`?`
unittests	`16.98% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-12-07T11:54:22Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11741

yadvr · 2024-12-07T21:08:46Z

@blueorangutan package

blueorangutan · 2024-12-07T21:10:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-07T22:15:06Z

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11744

NuxRo · 2024-12-07T23:33:56Z

@rohityadavcloud When I tried to install the RPMs in Fedora (ARM64) it really wanted libc.so.6(GLIBC_2.3) which was the version on the build system, but not on the Fedora system.
We might have to add "AutoReqProv: no" to the spec to leave the automatic deps behind.
"%global _filter_GLIBC_PRIVATE 1" might be a smaller hammer, but needs testing, not 100% sure it'll work, never used it.

yadvr · 2024-12-08T07:12:58Z

@blueorangutan package

blueorangutan · 2024-12-08T07:14:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-08T08:17:29Z

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 11747

blueorangutan · 2024-12-08T16:33:40Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11749

blueorangutan · 2024-12-08T18:46:56Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11750

weizhouapache · 2024-12-08T19:32:58Z

@blueorangutan package

blueorangutan · 2024-12-08T19:34:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-08T20:50:15Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11751

weizhouapache · 2024-12-08T22:22:37Z

@blueorangutan test

blueorangutan · 2024-12-08T22:24:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

yadvr · 2024-12-09T06:48:48Z

cc @NuxRo still doesn't work:

root@devcloud:~# dnf install cloudstack-common-4.20.1.0-1.noarch.rpm
Updating and loading repositories:
 Fedora 41 - aarch64 - Updates                                                                                                                   100% |  14.8 KiB/s |   6.7 KiB |  00m00s
 Fedora 41 - aarch64 - Updates                                                                                                                   100% |  71.9 KiB/s | 292.5 KiB |  00m04s
Repositories loaded.
Failed to resolve the transaction:
Problem: conflicting requests
  - nothing provides libc.so.6 needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.0) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.1) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.2) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.2.3) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.3) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
You can try to add to command line:
  --skip-broken to skip uninstallable packages

But the workaround was to rpm -ivh cloudstack-common-4.20.1.0-1.noarch.rpm --nodeps.

blueorangutan · 2024-12-09T13:31:53Z

[SF] Trillian test result (tid-11864)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52133 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10057-t11864-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

NuxRo · 2024-12-09T13:46:08Z

cc @NuxRo still doesn't work:

root@devcloud:~# dnf install cloudstack-common-4.20.1.0-1.noarch.rpm
Updating and loading repositories:
 Fedora 41 - aarch64 - Updates                                                                                                                   100% |  14.8 KiB/s |   6.7 KiB |  00m00s
 Fedora 41 - aarch64 - Updates                                                                                                                   100% |  71.9 KiB/s | 292.5 KiB |  00m04s
Repositories loaded.
Failed to resolve the transaction:
Problem: conflicting requests
  - nothing provides libc.so.6 needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.0) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.1) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.2) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.2.3) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.3) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
You can try to add to command line:
  --skip-broken to skip uninstallable packages

But the workaround was to rpm -ivh cloudstack-common-4.20.1.0-1.noarch.rpm --nodeps.

I'll try to find some time and test for a solution.
In theory if we specify all our deps correctly in the spec file then we can use "AutoReqProv: no" which should sort this problem out.

yadvr · 2024-12-17T07:51:32Z

@blueorangutan package

blueorangutan · 2024-12-17T07:52:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

packaging/el8/cloud.spec

blueorangutan · 2024-12-17T07:55:20Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11832

packaging/el8/cloud.spec

yadvr · 2024-12-30T08:05:58Z

@blueorangutan package

blueorangutan · 2024-12-30T09:43:10Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11945

github-actions · 2025-01-07T11:58:16Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

NuxRo

lgtm

yadvr · 2025-01-21T11:32:06Z

Thanks @NuxRo for testing this

@blueorangutan package

blueorangutan · 2025-01-21T11:34:06Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

yadvr · 2025-01-21T11:34:23Z

Pkgs built locally in my env here - https://build.yadav.cloud/cloudstack/pr/10057/el8/4.20/

nvazquez

LGTM

blueorangutan · 2025-01-21T12:41:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12148

DaanHoogland · 2025-01-21T12:48:35Z

no real smoke tests needed, but install on various platforms so running a matrix anyway #whatawaste ;)

DaanHoogland · 2025-01-21T12:48:45Z

@blueorangutan test matrix

blueorangutan · 2025-01-21T12:50:04Z

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

DaanHoogland · 2025-01-21T15:48:38Z

all smoke tests envs have started successfully. stopping thos to save lab space , but merging this

weizhouapache · 2025-01-21T16:00:43Z

cc @NuxRo still doesn't work:

root@devcloud:~# dnf install cloudstack-common-4.20.1.0-1.noarch.rpm
Updating and loading repositories:
 Fedora 41 - aarch64 - Updates                                                                                                                   100% |  14.8 KiB/s |   6.7 KiB |  00m00s
 Fedora 41 - aarch64 - Updates                                                                                                                   100% |  71.9 KiB/s | 292.5 KiB |  00m04s
Repositories loaded.
Failed to resolve the transaction:
Problem: conflicting requests
  - nothing provides libc.so.6 needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.0) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.1) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.2) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.2.3) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
  - nothing provides libc.so.6(GLIBC_2.3) needed by cloudstack-common-4.20.1.0-1.noarch from @commandline
You can try to add to command line:
  --skip-broken to skip uninstallable packages

But the workaround was to rpm -ivh cloudstack-common-4.20.1.0-1.noarch.rpm --nodeps.

just curious, has this issue been fixed ? is the workaround still needed ?
cc @rohityadavcloud @NuxRo

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

packaging: have noarch defined for rpms

19d0645

This makes rpms arch-independent Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr added this to the 4.20.1 milestone Dec 7, 2024

boring-cyborg bot added the component:packaging label Dec 7, 2024

Update cloud.spec

3637de0

Update cloud.spec

0b0c53c

yadvr added 4 commits December 8, 2024 23:28

Update cloud.spec

5934a12

Update cloud.spec

a8bec24

Update cloud.spec

5f2bcd2

Update cloud.spec

b2103cb

yadvr requested review from JoaoJandre and weizhouapache December 17, 2024 07:51

yadvr commented Dec 17, 2024

View reviewed changes

packaging/el8/cloud.spec Outdated Show resolved Hide resolved

yadvr commented Dec 30, 2024

View reviewed changes

packaging/el8/cloud.spec Outdated Show resolved Hide resolved

Update packaging/el8/cloud.spec

f94afd3

github-actions bot added the status:has-conflicts label Jan 7, 2025

NuxRo approved these changes Jan 17, 2025

View reviewed changes

Merge branch '4.20' into 420-rpm-buildnoarch

5a57a1c

github-actions bot removed the status:has-conflicts label Jan 21, 2025

nvazquez approved these changes Jan 21, 2025

View reviewed changes

DaanHoogland merged commit 96b757c into apache:4.20 Jan 21, 2025
26 checks passed

DaanHoogland deleted the 420-rpm-buildnoarch branch January 21, 2025 15:48

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

packaging: have noarch defined for rpms (apache#10057)

b9cdb40

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conversation

yadvr commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Uh oh!

yadvr commented Dec 7, 2024

Uh oh!

blueorangutan commented Dec 7, 2024

Uh oh!

codecov bot commented Dec 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Dec 7, 2024

Uh oh!

yadvr commented Dec 7, 2024

Uh oh!

blueorangutan commented Dec 7, 2024

Uh oh!

blueorangutan commented Dec 7, 2024

Uh oh!

NuxRo commented Dec 7, 2024

Uh oh!

yadvr commented Dec 8, 2024

Uh oh!

blueorangutan commented Dec 8, 2024

Uh oh!

blueorangutan commented Dec 8, 2024

Uh oh!

blueorangutan commented Dec 8, 2024

Uh oh!

blueorangutan commented Dec 8, 2024

Uh oh!

weizhouapache commented Dec 8, 2024

Uh oh!

blueorangutan commented Dec 8, 2024

Uh oh!

blueorangutan commented Dec 8, 2024

Uh oh!

weizhouapache commented Dec 8, 2024

Uh oh!

blueorangutan commented Dec 8, 2024

Uh oh!

yadvr commented Dec 9, 2024

Uh oh!

blueorangutan commented Dec 9, 2024

Uh oh!

NuxRo commented Dec 9, 2024

Uh oh!

yadvr commented Dec 17, 2024

Uh oh!

blueorangutan commented Dec 17, 2024

Uh oh!

Uh oh!

blueorangutan commented Dec 17, 2024

Uh oh!

Uh oh!

yadvr commented Dec 30, 2024

Uh oh!

blueorangutan commented Dec 30, 2024

Uh oh!

github-actions bot commented Jan 7, 2025

Uh oh!

NuxRo left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jan 21, 2025

Uh oh!

blueorangutan commented Jan 21, 2025

Uh oh!

yadvr commented Jan 21, 2025

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 21, 2025

Uh oh!

DaanHoogland commented Jan 21, 2025

Uh oh!

DaanHoogland commented Jan 21, 2025

yadvr commented Dec 7, 2024 •

edited

Loading

codecov bot commented Dec 7, 2024 •

edited

Loading