cks: prevent npe on cluster listing with removed offering

[shwstppr]

Description

NPE discussed in #10074

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (ef1a58d) to head (ba7eb54).
Report is 43 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...bernetes/cluster/KubernetesClusterManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10075      +/-   ##
============================================
- Coverage     15.12%   15.12%   -0.01%     
- Complexity    11255    11257       +2     
============================================
  Files          5408     5408              
  Lines        473838   473843       +5     
  Branches      57770    57771       +1     
============================================
- Hits          71676    71671       -5     
- Misses       394165   394175      +10     
  Partials       7997     7997              

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.84% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm, seems to do what is needed

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11771

[weizhouapache]

code lgtm

[weizhouapache]

line 564 to 566 were added in #7515, it should fix #10074
this pr is also good to have

[vladimirpetrov]

LGTM based on manual testing.