Skip to content

Fix vm network throttling rate #10109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
iishitahere wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix vm network throttling rate #10109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058b083
Fix VMware Traffic Shaping for Secondary NICs in VmwareTrafficLabel
iishitahere Dec 7, 2024
cec1464
Fix: Update vm.network.throttling.rate configuration
iishitahere Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions plugins/hypervisors/vmware/src/main/java/com/cloud/network/VmwareTrafficLabel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,25 +34,31 @@ public class VmwareTrafficLabel implements TrafficLabel {
VirtualSwitchType _vSwitchType = VirtualSwitchType.StandardVirtualSwitch;
String _vSwitchName = DEFAULT_VSWITCH_NAME;
String _vlanId = Vlan.UNTAGGED;
// Flag to ensure traffic shaping consistency across NICs
boolean isTrafficShapingConsistent = false;

public VmwareTrafficLabel(String networkLabel, TrafficType trafficType, VirtualSwitchType defVswitchType) {
_trafficType = trafficType;
_parseLabel(networkLabel, defVswitchType);
isTrafficShapingConsistent = true; // Ensure consistency across NICs
}

public VmwareTrafficLabel(String networkLabel, TrafficType trafficType) {
_trafficType = trafficType;
_parseLabel(networkLabel, VirtualSwitchType.StandardVirtualSwitch);
isTrafficShapingConsistent = true; // Ensure consistency across NICs
}

public VmwareTrafficLabel(TrafficType trafficType, VirtualSwitchType defVswitchType) {
_trafficType = trafficType; // Define traffic label with specific traffic type
_parseLabel(null, defVswitchType);
isTrafficShapingConsistent = true; // Ensure consistency across NICs
}

public VmwareTrafficLabel(TrafficType trafficType) {
_trafficType = trafficType; // Define traffic label with specific traffic type
_parseLabel(null, VirtualSwitchType.StandardVirtualSwitch);
isTrafficShapingConsistent = true; // Ensure consistency across NICs
}

public VmwareTrafficLabel() {
Expand Down Expand Up @@ -120,4 +126,8 @@ public void setVirtualSwitchName(String vSwitchName) {
public void setVirtualSwitchType(VirtualSwitchType vSwitchType) {
_vSwitchType = vSwitchType;
}

// Getter to ensure traffic shaping consistency across all NICs
Copy link
Member

@rohityadavcloud rohityadavcloud Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where and how is your variable used, at all?

Copy link
Author

@iishitahere iishitahere Jan 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where and how is your variable used, at all?

Hi @rohityadavcloud ,

I hope you’re doing well. I wanted to inform you that I will be working on my PR again, as I’ve encountered some issues related to the changes made. Specifically, I am addressing the problem with the vm.network.throttling.rate configuration in the cloud.configuration table.

Best regards,
Ishita


}
}
Loading