Add project-user association normalization script to 4.20.1 upgrade #10116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10116 +/- ##
=========================================
Coverage 16.03% 16.03%
- Complexity 12814 12815 +1
=========================================
Files 5637 5637
Lines 493507 493507
Branches 59831 59831
=========================================
Hits 79131 79131
Misses 405600 405600
Partials 8776 8776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
winterhazel
force-pushed
the
fix-deletion-of-users-associated-to-projects-4.20
branch
from
3ef5e7a to
09d85a7
Compare
JoaoJandre
approved these changes
Dec 18, 2024
shwstppr
approved these changes
Jan 16, 2025
DaanHoogland
approved these changes
Jan 16, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
NOTE: This will not be in 4.20 -> 21 , so if 20.1 comes out before 21 we need to reimpleme nt it.
DaanHoogland
added a commit
that referenced
this pull request
Jan 20, 2025
* 4.20: Maintenance mode: Add host to deployment planner avoid list to fix local storage vm migration (#9892) Add project-user association normalization script to 4.20.1 upgrade (#10116) fix slider component for global settings of the range type (#10187) Clean up network permissions on account deletion (#10176)
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the cleanup script from #10008 to the 4.20.1.0 upgrade in order to normalize environments that were updated to 4.20 and will not go through the 4.19.2 script.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Without the changes in #10008, I created some broken projects by deleting their users. Then, I executed the upgrade script and verified that I was able to list their accounts/users normally.