Conversation
Pearl1594
requested review from
DaanHoogland,
GabrielBrascher,
GutoVeronezi,
NuxRo,
SadiJr,
borisstoyanov,
gsirett,
harikrishna-patnala,
jbampton,
kiranchavala,
kishankavala,
kiwiflyer,
mlsorensen,
nvazquez,
pdion891,
rafaelweingartner,
rajujith,
resmo,
rp-,
shwstppr,
soreana,
sureshanaparti,
svenvogel,
swill,
utchoang,
vishesh92,
vladimirpetrov,
winterhazel and
yadvr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10125 +/- ##
=========================================
Coverage 16.06% 16.06%
- Complexity 12863 12864 +1
=========================================
Files 5642 5642
Lines 493856 493856
Branches 59860 59860
=========================================
+ Hits 79324 79326 +2
Misses 405749 405749
+ Partials 8783 8781 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
To be honest, I don't really like this PR. Not that it matters to me whether it's Christmas or any other festival in any religion. It shouldn't have anything to do with this project... and a simple Merry Christmas to the ones who celebrate on the ML should be enough. Just my 2 cents. |
I like your killjoy attitude @resmo (no sarcasm, really) |
|
I'm normally accused of being the Christmas grinch, I think @resmo is bidding for my title :-) Happy Christmas (to those that celebrate) and a peaceful new year to everybody in this community |
|
nvazquez
left a comment
nvazquez
left a comment
There was a problem hiding this comment.
Merry Christmas and happy new year all! 💪🏼
|
@resmo pls improve on the code so that we can eventually merge it. I see sooooooo many people are asked to review - this is hardly ever going to be merged, damn it.... (not that I care about holidays that much :D ) |
andrijapanicsb
left a comment
andrijapanicsb
left a comment
There was a problem hiding this comment.
What Christmas, 25th December 2024 or 7th January 2025?
Code is unclear. There are no proper logging messages. Have the smoke tests passed for major hypervisors?
|
Merry Christmas and Happy Holidays 🎉 ! |
JoaoJandre
left a comment
JoaoJandre
left a comment
There was a problem hiding this comment.
Happy holidays to everyone 🎅
|
Merry Christmas and Happy New Year everybody! |
BryanMLima
left a comment
BryanMLima
left a comment
There was a problem hiding this comment.
Happy holidays everyone!!
@andrijapanicsb , since you are blocking this High-prio and time-sensitive PR, please add suggestions to make its progress possible. i.e. add log messages to add/specify the missing smoke tests. Please make it as easy on the contributor as possible to have their changes adopted! |
sureshanaparti
left a comment
sureshanaparti
left a comment
There was a problem hiding this comment.
Happy Christmas and New Year!
vladimirpetrov
left a comment
vladimirpetrov
left a comment
There was a problem hiding this comment.
Happy holidays to all of you!
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
Happy Christmas and New Year!
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
Merry Christmas and happy new year all! Looking forward to another great year of collaboration!
soreana
left a comment
soreana
left a comment
There was a problem hiding this comment.
Wishing everyone a Merry Christmas and a Happy New Year! Excited for another fantastic year of working together!
19 participants
Description
To all of the CloudStack contributors - Merry Christmas and Happy Holidays!
/cc alphabetically-ish @abh1sar @alexandremattioli @andrijapanicsb @borisstoyanov @BryanMLima @bernardodemarco @chiradeep @DaanHoogland @GabrielBrascher @GaOrtiga @gsirett @GutoVeronezi @harikrishna-patnala @hsato03 @rajujith @jbampton @JoaoJandre @kiwiflyer @kiranchavala @kishankavala @mlsorensen @msinhore @NuxRo @nvazquez @PeterBackroll @pdion891 @rafaelweingartner @resmo @RodrigoDLopez @rohityadavcloud @rp- @SadiJr @shwstppr @slavkap @soreana @steveroles @SadiJr @sureshanaparti @svenvogel @swill @syed @utchoang @vishesh92 @vladimirpetrov @winterhazel @weizhouapache @wido and so many others! (I may have missed quite a few - you're all in my thoughts)