Skip to content

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Dec 20, 2024

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.06%. Comparing base (631bba2) to head (0812331).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10131   +/-   ##
=========================================
  Coverage     16.06%   16.06%           
+ Complexity    12872    12871    -1     
=========================================
  Files          5642     5642           
  Lines        493973   493973           
  Branches      59895    59895           
=========================================
  Hits          79351    79351           
  Misses       405837   405837           
  Partials       8785     8785           
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11901

@DaanHoogland
Copy link
Contributor

I don't think this needs more than the GHA to prove itself.

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vishesh92 vishesh92 merged commit 0b66f5a into apache:main Dec 31, 2024
26 checks passed
@jbampton jbampton deleted the trailing-whitespace-more branch December 31, 2024 12:13
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants