-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Removal of UI blockage to access the changeOfferingForVolume API
#10135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of UI blockage to access the changeOfferingForVolume API
#10135
Conversation
changeOfferingForVolume API
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10135 +/- ##
============================================
- Coverage 16.30% 16.30% -0.01%
+ Complexity 13450 13447 -3
============================================
Files 5675 5675
Lines 499249 499249
Branches 60377 60377
============================================
- Hits 81425 81420 -5
- Misses 408753 408757 +4
- Partials 9071 9072 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
Co-authored-by: dahn <[email protected]>
2e274bf to
cd511c0
Compare
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
@blueorangutan package |
|
@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14654 |
rosi-shapeblue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification passed. Working as expected.
Tested with a non-admin user assigned to a custom role allowing changeOfferingForVolume. The “Change Offering” icon is now visible in the UI, and the offering change works as expected.
NOTE: Minor UI i18n issue: message.change.offering.for.volume.processing key is shown instead of a user-friendly message.
Screencast.from.2025-10-12.17-01-11.webm
LGTM.
|
@shwstppr @weizhouapache , are you gouys alright with this to merge now? |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Description
This PR corrects an incorrect behavior in the UI where users who have access to the
changeOfferingForVolumeAPI, but are not admins, cannot use it.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
A role was created (based on the default user role) with permission to access the
changeOfferingForVolumeAPI.An account and a user were created using this role.
The
changeOfferingForVolumeAPI icon appeared correctly in the UI (npm run server).The change in the volume offer was made correctly