Skip to content

Conversation

@LayonRibeiro
Copy link
Contributor

Description

This PR corrects an incorrect behavior in the UI where users who have access to the changeOfferingForVolume API, but are not admins, cannot use it.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before

2024-12-22_23-01

After

2024-12-22_23-02

How Has This Been Tested?

  1. A role was created (based on the default user role) with permission to access the changeOfferingForVolume API.

  2. An account and a user were created using this role.

  3. The changeOfferingForVolume API icon appeared correctly in the UI (npm run server).

  4. The change in the volume offer was made correctly

@LayonRibeiro LayonRibeiro changed the title Show icon to changeOfferingForVolume for the other users Removal of UI blockage to access the changeOfferingForVolume API Dec 23, 2024
@shwstppr
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.30%. Comparing base (0934fb1) to head (376bd4f).
⚠️ Report is 574 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10135      +/-   ##
============================================
- Coverage     16.30%   16.30%   -0.01%     
+ Complexity    13450    13447       -3     
============================================
  Files          5675     5675              
  Lines        499249   499249              
  Branches      60377    60377              
============================================
- Hits          81425    81420       -5     
- Misses       408753   408757       +4     
- Partials       9071     9072       +1     
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests 17.16% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-504)

@LayonRibeiro LayonRibeiro force-pushed the PR-Remove-UI-Blockage-on-Change-Volume-Offering branch from 2e274bf to cd511c0 Compare January 31, 2025 15:26
@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-638)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@rosi-shapeblue rosi-shapeblue self-assigned this Aug 17, 2025
@rosi-shapeblue
Copy link
Collaborator

@blueorangutan package

@blueorangutan
Copy link

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14654

Copy link
Collaborator

@rosi-shapeblue rosi-shapeblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification passed. Working as expected.

Tested with a non-admin user assigned to a custom role allowing changeOfferingForVolume. The “Change Offering” icon is now visible in the UI, and the offering change works as expected.

NOTE: Minor UI i18n issue: message.change.offering.for.volume.processing key is shown instead of a user-friendly message.

Screenshot from 2025-10-12 17-02-33 Screenshot from 2025-10-12 16-59-25 Screenshot from 2025-10-12 16-59-16
Screencast.from.2025-10-12.17-01-11.webm

LGTM.

@DaanHoogland
Copy link
Contributor

@shwstppr @weizhouapache , are you gouys alright with this to merge now?

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache merged commit 136ea3e into apache:main Oct 13, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 13, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants