Skip to content

Conversation

@jbampton
Copy link
Member

@jbampton jbampton commented Dec 28, 2024

and fix license header

https://github.com/DavidAnson/markdownlint/blob/main/doc/md009.md

https://github.com/DavidAnson/markdownlint/blob/main/doc/md019.md

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.07%. Comparing base (0b66f5a) to head (815227a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10145   +/-   ##
=========================================
  Coverage     16.07%   16.07%           
  Complexity    12885    12885           
=========================================
  Files          5642     5642           
  Lines        494039   494039           
  Branches      59912    59912           
=========================================
+ Hits          79406    79407    +1     
+ Misses       405829   405828    -1     
  Partials       8804     8804           
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11931

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11937

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vishesh92
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11956

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Dec 31, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11956

looking if I can build the debian one, I see no sensible error in the backend.

11:05:20 ERROR: We couldn't grab the PR title. Something went wrong querying the GitHub API.
11:05:20 
11:05:20 Build step 'Execute shell' marked build as failure

It would seem that if this were genuine it would have broken the el builds as well.
note: this error comes from the git-pr script.

@DaanHoogland DaanHoogland changed the title pre-commit update markdownlint; enable rules MD009,MD019; fix license… pre-commit update markdownlint; enable rules MD009,MD019 Dec 31, 2024
@DaanHoogland DaanHoogland force-pushed the enable-markdownlint-rules-MD009-and-MD019 branch from 470d7a6 to 815227a Compare December 31, 2024 10:29
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11958

@DaanHoogland
Copy link
Contributor

GHA are proofing this one, merging

@DaanHoogland DaanHoogland merged commit 0128046 into apache:main Dec 31, 2024
26 checks passed
@jbampton jbampton deleted the enable-markdownlint-rules-MD009-and-MD019 branch December 31, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants