Add pre-commit hook fix-byte-order-marker

[jbampton]

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#fix-byte-order-marker

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.06%. Comparing base (b48de4e) to head (85fe3d7).
Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #10147   +/-   ##
=========================================
  Coverage     16.06%   16.06%           
- Complexity    12871    12872    +1     
=========================================
  Files          5642     5642           
  Lines        493973   493973           
  Branches      59895    59895           
=========================================
+ Hits          79348    79351    +3     
+ Misses       405839   405837    -2     
+ Partials       8786     8785    -1     

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.90% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11932

[vishesh92]

clgtm. can be merged after the tests are complete.
@blueorangutan test

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12021)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60466 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10147-t12021-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	407.37	test_vm_life_cycle.py
test_01_redundant_vpc_site2site_vpn	Failure	482.45	test_vpc_vpn.py

[DaanHoogland]

tryin insanity here

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12029)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 68180 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10147-t12029-kvm-ol8.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	99.37	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	50.72	test_vm_life_cycle.py
test_08_migrate_vm	Error	46.09	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	Error	100.64	test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure	Failure	52.19	test_vm_strict_host_tags.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Error	4321.21	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Error	4321.38	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	Error	3613.38	test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance	Error	305.23	test_hostha_kvm.py