Skip to content

SSL_Handshake: close nio channel when NioClient fail to handshake wit… #10153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bulleting0724 wants to merge 2 commits into from
Closed

SSL_Handshake: close nio channel when NioClient fail to handshake wit… #10153

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eab6df
SSL_Handshake: close nio channel when NioClient fail to handshake wit…
Dec 24, 2024
3f3f7d0
Merge branch 'main' into nio_channel_close
bulleting0724 Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions utils/src/main/java/com/cloud/utils/nio/NioClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
_selector.close();
Copy link
Contributor

@shwstppr shwstppr Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well?

throw new IOException("Failed to initialise security", e);
} catch (final IOException e) {
_clientConnection.close();

Check warning on line 82 in utils/src/main/java/com/cloud/utils/nio/NioClient.java

View check run for this annotation

Codecov / codecov/patch

utils/src/main/java/com/cloud/utils/nio/NioClient.java#L82 

Added line #L82 was not covered by tests
Copy link

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider wrapping _clientConnection.close() in a try-catch block to ensure that any exception thrown during the close operation does not obscure the original IOException and to better manage resource cleanup.

Suggested change
_clientConnection.close();
try {
_clientConnection.close();
} catch (final IOException closeException) {
logger.error("Failed to close _clientConnection", closeException);
}

Copilot uses AI. Check for mistakes.
_selector.close();
throw e;
}
Expand Down
Loading