Allow creation of Shared Networks without IP range if network offering has no services - specifyvlan = true

[Pearl1594]

Description

Fixes: #10114
This PR adds necessary check for IP range for shared Networks.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@Pearl1594 in the expected result in #10114 it says

VM should get successfully deployed with ACS automatically allocating a VLAN

So that is not true? instead it is

VM deployment should fail with an appropriate error message

?

[DaanHoogland]

code looks good if we accept that deployment fails.

[Pearl1594]

@Pearl1594 in the expected result in #10114 it says

VM should get successfully deployed with ACS automatically allocating a VLAN

So that is not true? instead it is

VM deployment should fail with an appropriate error message

?

Initially when I reported the issue, I thought the issue was with specifyVlan - as broadcast URI ends up being null. However, on further investigation the reason for it was IP address not being passed. With missing inputs it's not possible to have a successful deployment.
I will change the issue description.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (f652ad0) to head (665283a).
Report is 16 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10168   +/-   ##
=========================================
  Coverage     15.14%   15.14%           
- Complexity    11282    11283    +1     
=========================================
  Files          5408     5408           
  Lines        473823   473825    +2     
  Branches      57826    57827    +1     
=========================================
+ Hits          71763    71764    +1     
  Misses       394038   394038           
- Partials       8022     8023    +1     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.86% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[DaanHoogland]

@Pearl1594 can you update on this?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm

[DaanHoogland]

@bernardodemarco @weizhouapache are your questions addressed to satisfaction?

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12224

[bernardodemarco]

clgtm

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Pearl1594]

I think this PR needs some more work, as there is a case that when we do not have any services provided by the network offering used by the shared network, it essentially behaves like an L2 network; hence there shouldn't be a need to specify IP range. However, when an IP range isn't specified, the nic is created with no broadcast_uri, which eventually results in an NPE on the agent side. Would need some investigation. cc @DaanHoogland @weizhouapache @sureshanaparti
We may want to move this to 4.20.1

[weizhouapache]

code lgtm

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12243

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12209)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47529 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10168-t12209-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.05	test_ssvm.py
test_04_cpvm_internals	Failure	0.05	test_ssvm.py
test_01_secure_vm_migration	Error	134.38	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	134.38	test_vm_life_cycle.py

[blueorangutan]

[SF] Trillian test result (tid-12213)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45032 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10168-t12213-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestClusterDRS>:setup	Error	0.00	test_cluster_drs.py

[DaanHoogland]

clgtm

[DaanHoogland]

the proper error message is returned (tested in a lab env)