[KVM] Add watchdog model none to disable use of watchdogs on KVM agent

[nvazquez]

Description

This PR allows the value none for the property vm.watchdog.model on the agent.properties file. When value is set to none then no watchdogs are created for the VM deployments

For EL9 hosts on ARM64: VM deployments fail with error:

2025-01-17T23:31:51.072699Z qemu-kvm: -device {"driver":"i6300esb","id":"watchdog0","bus":"pci.8","addr":"0x1"}: 'i6300esb' is not a valid device model name

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.14%. Comparing base (96b757c) to head (32fa184).
Report is 1 commits behind head on 4.20.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10203   +/-   ##
=========================================
  Coverage     16.13%   16.14%           
- Complexity    12972    12973    +1     
=========================================
  Files          5639     5639           
  Lines        494297   494299    +2     
  Branches      59908    59909    +1     
=========================================
+ Hits          79773    79789   +16     
+ Misses       405698   405684   -14     
  Partials       8826     8826           

Flag	Coverage Δ
uitests	4.02% <ø> (ø)
unittests	16.99% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12111

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12118

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12119

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[NuxRo]

LGTM based on hands-on testing

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12154

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12161)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53693 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10203-t12161-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	Error	1.25	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	2.37	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	2.37	test_ipv4_routing.py

[weizhouapache]

code lgtm

minor advise: can you update agent.properties as well ?

cloudstack/agent/conf/agent.properties

Lines 287 to 289 in 81e052c

	# The model of Watchdog timer to present to the Guest.
	# For all models refer to the libvirt documentation.
	#vm.watchdog.model=i6300esb

[nvazquez]

Thanks @weizhouapache, added it now