Configure org.eclipse.jetty.server.Request.maxFormKeys from server.properties and increase the default value

[abh1sar]

Description

Fixes #9667

Details

This pull request introduces a new configuration option for the Apache CloudStack project to limit the maximum number of form keys allowed in API requests. The changes include:

• Adding a new configuration property request.max.form.keys with a default value of 5000 in server.properties.in.
• Updating the ServerDaemon class to handle request.max.form.keys:
  • Defining constants for the new property key and its default value.
  • Adding a new instance variable maxFormKeys.
  • Initializing the new property from the configuration file.
  • Setting the new property in the server attributes and web application context.
  • Adding a setter method for the new property.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested importRoles UI using the below csv file
roletest.csv

Before change : 404 error
Works after change.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.13%. Comparing base (188eacd) to head (e3be88d).
Report is 16 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19   #10214    +/-   ##
==========================================
  Coverage     15.12%   15.13%            
- Complexity    11266    11280    +14     
==========================================
  Files          5408     5408            
  Lines        473900   474003   +103     
  Branches      57791    57821    +30     
==========================================
+ Hits          71698    71747    +49     
- Misses       394199   394235    +36     
- Partials       8003     8021    +18     

Flag	Coverage Δ
uitests	4.30% <ø> (+<0.01%)	⬆️
unittests	15.85% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12131

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[kiranchavala]

LGTM, uploaded the following csv file and the issue got fixed

https://gist.github.com/scottsignal/737022dba6f3d3b7847d3d0665adc6f3

Before fix, upload the csv file, exception is thrown

After fix there is no error and import is done successfully

[blueorangutan]

[SF] Trillian test result (tid-12136)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58018 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10214-t12136-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_secured_to_nonsecured_vm_migration	Error	397.24	test_vm_life_cycle.py