-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: set redundant state as N/A for non-redundant routers #10227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: set redundant state as N/A for non-redundant routers #10227
Conversation
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10227 +/- ##
============================================
+ Coverage 15.13% 15.85% +0.72%
Complexity 11275 11275
============================================
Files 5408 5042 -366
Lines 474007 444437 -29570
Branches 57822 52642 -5180
============================================
- Hits 71728 70457 -1271
+ Misses 394260 366106 -28154
+ Partials 8019 7874 -145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
nvazquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM

Description
This PR fixes #9674
screenshot

Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?