Skip to content

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jan 21, 2025

Description

This PR fixes #9674

screenshot
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@weizhouapache weizhouapache linked an issue Jan 21, 2025 that may be closed by this pull request
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10227 (QA-JID-518)

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.85%. Comparing base (1ff68cf) to head (f934fea).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10227      +/-   ##
============================================
+ Coverage     15.13%   15.85%   +0.72%     
  Complexity    11275    11275              
============================================
  Files          5408     5042     -366     
  Lines        474007   444437   -29570     
  Branches      57822    52642    -5180     
============================================
- Hits          71728    70457    -1271     
+ Misses       394260   366106   -28154     
+ Partials       8019     7874     -145     
Flag Coverage Δ
uitests ?
unittests 15.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

tested in qa , list view works:
image

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@weizhouapache weizhouapache marked this pull request as ready for review January 21, 2025 13:27
@DaanHoogland DaanHoogland merged commit 91f1ada into apache:4.19 Jan 21, 2025
25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-ui-redundant-state branch January 21, 2025 13:29
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VR Redundant State not accurate for Single Virtual Router

4 participants