api/ui: add specifyvlan to network response #10236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10236 +/- ##
============================================
- Coverage 15.13% 15.13% -0.01%
+ Complexity 11279 11275 -4
============================================
Files 5408 5408
Lines 474007 474011 +4
Branches 57822 57822
============================================
- Hits 71746 71729 -17
- Misses 394240 394264 +24
+ Partials 8021 8018 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12175 |
bernardodemarco
approved these changes
Jan 29, 2025
Member
bernardodemarco
left a comment
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, manually tested in a local environment:
- Created a shared network with a specified VLAN.
- Created a domain admin account.
- Accessed the details of the network with the domain admin account, and verified that the operation icons were disabled:
- Created a shared network without a specified VLAN.
- Verified that operation icons were enabled for the domain admin account:
rg9975
pushed a commit
to rg9975/cloudstack
that referenced
this pull request
Jan 31, 2025
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #9757
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?