ui: fix passing vlan while creating vpc tier #10239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently VLAN was not getting added to API call when offering has specifyVla as true Signed-off-by: Abhishek Kumar <[email protected]>
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10239 +/- ##
=========================================
Coverage 15.13% 15.13%
- Complexity 11274 11277 +3
=========================================
Files 5408 5408
Lines 473974 474007 +33
Branches 57813 57822 +9
=========================================
+ Hits 71730 71735 +5
- Misses 394227 394253 +26
- Partials 8017 8019 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Jan 22, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm
tested with and without in qa and change confirmed to work
rg9975
pushed a commit
to rg9975/cloudstack
that referenced
this pull request
Jan 31, 2025
Signed-off-by: Abhishek Kumar <[email protected]>
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently VLAN was not getting added to API call when offering has specifyVlan as true
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Error before the fix,
vpc-tier-vlan.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?