Skip to content

server: apply network ACL even if there is no network ACLs in the ACL list (#9374) #10241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 1 commit into from
May 1, 2025
Merged

server: apply network ACL even if there is no network ACLs in the ACL list (#9374) #10241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions server/src/main/java/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,6 @@ public boolean associatePublicIP(final Network network, final List<? extends Pub
public boolean applyNetworkACLs(final Network network, final List<? extends NetworkACLItem> rules, final VirtualRouter router, final boolean isPrivateGateway)
throws ResourceUnavailableException {

if (rules == null || rules.isEmpty()) {
logger.debug("No network ACLs to be applied for network {}", network);
return true;
}

logger.debug("APPLYING NETWORK ACLs RULES");

final String typeString = "network acls";
Expand Down