ssvm: reset fields on destroy

[shwstppr]

Description

Fixes #8103

Added cleanup changes for SSVM that already exist for CPVM

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (9967bb3) to head (4001f76).
Report is 132 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../secondarystorage/SecondaryStorageManagerImpl.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10253      +/-   ##
============================================
+ Coverage     15.13%   15.14%   +0.01%     
- Complexity    11274    11283       +9     
============================================
  Files          5408     5408              
  Lines        473974   473823     -151     
  Branches      57813    57822       +9     
============================================
+ Hits          71730    71764      +34     
+ Misses       394227   394037     -190     
- Partials       8017     8022       +5     

Flag	Coverage Δ
uitests	4.29% <ø> (-0.01%)	⬇️
unittests	15.86% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13384

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13308)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48769 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10253-t13308-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

tested ok by examining the DB.
before private mac wasn’t cleared, now it is.

but not everything seems to be cleared. mac/ip/mask and gw for the PublicNetworkGuru do not get cleared from the DB. I do not think that is related to this improvement, just something I noticed. This is true for both CPVM and SSVM. Any thoughts @shwstppr ? whether or not, I think we can merge.

[shwstppr]

@DaanHoogland did a quick check and I think the clearing of mac/ip/mask and gw for the PublicNetworkGuru can be a separate work. Should we merge this PR & create a new issue?