Skip to content

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jan 23, 2025

Description

This PR fixes the duplicated lines with /var/www/html/latest/.htaccess
see #10205 (comment)

this issue does not exist with 4.19

how to apply it in an existing 4.20 environment:
#10184 (reply in thread)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.20.1 milestone Jan 23, 2025
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.98%. Comparing base (96b757c) to head (95a1263).
Report is 72 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10254      +/-   ##
============================================
+ Coverage     16.13%   16.98%   +0.85%     
  Complexity    12972    12972              
============================================
  Files          5639     5245     -394     
  Lines        494297   461951   -32346     
  Branches      59908    54194    -5714     
============================================
- Hits          79773    78484    -1289     
+ Misses       405698   374789   -30909     
+ Partials       8826     8678     -148     
Flag Coverage Δ
uitests ?
unittests 16.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12190

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-12178)

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache weizhouapache marked this pull request as ready for review January 24, 2025 10:14
@blueorangutan
Copy link

[SF] Trillian test result (tid-12182)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51057 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10254-t12182-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.26 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 1.38 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 1.38 test_ipv4_routing.py

@DaanHoogland
Copy link
Contributor

Issue poster confirmed the fix. just want to see if the ipv4 routing failures are intermitted.

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

Issue poster confirmed the fix. just want to see if the ipv4 routing failures are intermitted.

@DaanHoogland
the failures are addressed by #10252

@blueorangutan
Copy link

[SF] Trillian test result (tid-12271)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55707 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10254-t12271-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 1.24 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.33 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 2.33 test_ipv4_routing.py

@Pearl1594 Pearl1594 linked an issue Feb 11, 2025 that may be closed by this pull request
@Pearl1594 Pearl1594 merged commit 789f94b into apache:4.20 Feb 14, 2025
24 of 25 checks passed
@DaanHoogland DaanHoogland deleted the 4.20-fix-vr-htaccess branch February 14, 2025 15:48
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

CloudStack fails to start more VMs

4 participants