VPC: fix private mtu of vpc tier

[weizhouapache]

Description

This PR fixes #10001

Steps to reproduce the issue

• update global setting for public/private mtu from 1500 to 1450
• create vpc, the public/private mtu is 1450/1450
• create vpc tier

expected result: public/private mtu is 1450/1450
actual result: public/private mtu is 1450/1500

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (2075918) to head (74505a8).
Report is 64 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19   #10257    +/-   ##
==========================================
  Coverage     15.14%   15.14%            
- Complexity    11278    11313    +35     
==========================================
  Files          5408     5413     +5     
  Lines        473803   474709   +906     
  Branches      57819    57894    +75     
==========================================
+ Hits          71743    71911   +168     
- Misses       394039   394753   +714     
- Partials       8021     8045    +24     

Flag	Coverage Δ
uitests	4.29% <ø> (-0.01%)	⬇️
unittests	15.87% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Pearl1594]

code LGTM

[Pearl1594]

@weizhouapache Could you please address the comment provided? Thanks.

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12588

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12600

[blueorangutan]

[SF] Trillian test result (tid-12504)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47731 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10257-t12504-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

@weizhouapache is this ready for review/test/merge?

[weizhouapache]

@weizhouapache is this ready for review/test/merge?

yes @DaanHoogland

[DaanHoogland]

verified in lab env

[weizhouapache]

verified in lab env

great. thanks @DaanHoogland !