Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR fixes: #10220
image

Before fix:

id,protocol,startport,endport,traffictype,state,cidrlist,tags,aclid,aclname,number,action,fordisplay,reason
63cefab0-e714-4d5c-808c-a438ba27f7c5,tcp,80,80,Ingress,Active,10.0.0.0/24,"",0f8fa3ad-baa5-473c-9431-54a57a7584d8,custom,1,Allow,true,rule 

After fix:

id,protocol,startport,endport,traffictype,state,cidrlist,tags,aclid,aclname,number,action,fordisplay,reason
63cefab0-e714-4d5c-808c-a438ba27f7c5,tcp,80,80,Ingress,Active,10.0.0.0/24,"",0f8fa3ad-baa5-473c-9431-54a57a7584d8,custom,1,Allow,true,rule #1
5e5a1d56-4546-4fb9-9ca9-fc671ac90468,all,undefined,undefined,Ingress,Active,10.10.10.0/24,"",0f8fa3ad-baa5-473c-9431-54a57a7584d8,custom,2,Allow,true,two

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clgtm

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (c9fea62) to head (339c401).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10259   +/-   ##
=========================================
  Coverage     15.14%   15.14%           
- Complexity    11283    11285    +2     
=========================================
  Files          5408     5408           
  Lines        473822   473822           
  Branches      57825    57825           
=========================================
+ Hits          71771    71775    +4     
+ Misses       394026   394023    -3     
+ Partials       8025     8024    -1     
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10259 (QA-JID-529)

@DaanHoogland
Copy link
Contributor

tested qa

@DaanHoogland DaanHoogland merged commit 2aa2e92 into 4.19 Jan 23, 2025
48 of 49 checks passed
@DaanHoogland DaanHoogland deleted the fix-acl-export branch January 23, 2025 19:10
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export ACLs results in incomplete CSV-file if description contains hash-character

4 participants