Minor fixes for references to Pure Storage FlashArray

[sdodsley]

Description

This PR changes incorrect references to the Pure Storage FlashArray in both the actual code and in code comments.

Just wanting to make sure that the array is referenced by it correct, trademarked, name.

No functional changes.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

None

How Has This Been Tested?

N/A

How did you try to break this feature and the system with this change?

N/A

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

• In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
• Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
• Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
• Be sure to read the CloudStack Coding Conventions.
  Apache CloudStack is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html)
  Slack: https://apachecloudstack.slack.com/

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.19%. Comparing base (98f5663) to head (d04f124).
⚠️ Report is 772 commits behind head on main.

Files with missing lines	Patch %	Lines
...e/adapter/flasharray/FlashArrayAdapterFactory.java	0.00%	1 Missing ⚠️
...ovider/FlashArrayPrimaryDatastoreProviderImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #10271   +/-   ##
=========================================
  Coverage     16.19%   16.19%           
  Complexity    13051    13051           
=========================================
  Files          5645     5645           
  Lines        494567   494567           
  Branches      59955    59955           
=========================================
  Hits          80088    80088           
  Misses       405642   405642           
  Partials       8837     8837           

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	17.04% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12217

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12192)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10271-t12192-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	Error	2.25	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	2.35	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	2.35	test_ipv4_routing.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15404

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15427

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[DaanHoogland]

@sdodsley did you test this in anyway? We have no access to do a 3rd party test.

[sureshanaparti]

@sdodsley Could you check if the upgrade path should update the provider name for any existing providers with "Flash Array" to "FlashArray".

[blueorangutan]

[SF] Trillian test result (tid-14645)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55633 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10271-t14645-kvm-ol8.zip
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[sdodsley]

@sdodsley Could you check if the upgrade path should update the provider name for any existing providers with "Flash Array" to "FlashArray".

I see no reason why an upgrade path needs to do this. This is purely a cosmetic, copyright, change

[DaanHoogland]

clgtm