-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Fill username & domain fields in login, forgotPassword and resetPassword page from url #10291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd4db8c to
132ce29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10291 +/- ##
============================================
- Coverage 16.15% 16.15% -0.01%
Complexity 12987 12987
============================================
Files 5639 5639
Lines 494148 494153 +5
Branches 59916 59923 +7
============================================
Hits 79854 79854
- Misses 405465 405470 +5
Partials 8829 8829
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
|
@vishesh92 can you please add some testing guidance in the description? |
@DaanHoogland updated the description. |
|
tested in qa |
NuxRo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, great idea
Description
If the URL params contains
usernameordomain, it will use the values for the username and domain field in Login, forgot password and reset password page. This feature would be useful if you want to open a page which has prefilled usename and/or domain. To test the forgot password and reset password page, you need to enable theuser.password.reset.enabledglobal setting.e.g. The below url will look like this when opened.
https://qa.cloudstack.cloud/simulator/pr/10291/#/user/login?username=admin&domain=ABC
Generated description
This pull request includes changes to the forms in the authentication views to support additional query parameters. The most important changes involve updating the
ForgotPassword,Login, andResetPasswordcomponents to includeusernameanddomainfrom the route query.Enhancements to authentication forms:
ui/src/views/auth/ForgotPassword.vue: Addedusernameanddomainto the reactive form object, using values from the route query if available.ui/src/views/auth/Login.vue: Addedusernameanddomainto the reactive form object, using values from the route query if available.ui/src/views/auth/ResetPassword.vue: Addeddomainto the reactive form object, using values from the route query if available.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?