ui: fix loading for hypervisor filter in serachview #10292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier even after fetch hypervisors, the UI list element was showing loading animation Signed-off-by: Abhishek Kumar <[email protected]>
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10292 +/- ##
============================================
+ Coverage 15.13% 15.14% +0.01%
- Complexity 11274 11283 +9
============================================
Files 5408 5408
Lines 473974 473825 -149
Branches 57813 57827 +14
============================================
+ Hits 71730 71771 +41
+ Misses 394227 394029 -198
- Partials 8017 8025 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Jan 29, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, tested in qa
kiranchavala
approved these changes
Jan 29, 2025
Contributor
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM, Tested on the qa server
rg9975
pushed a commit
to rg9975/cloudstack
that referenced
this pull request
Jan 31, 2025
Signed-off-by: Abhishek Kumar <[email protected]>
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier even after fetching hypervisors, the UI list element was showing loading animation
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
How did you try to break this feature and the system with this change?