changed the kubernetestool url

[kiranchavala]

Description

Currently, if we execute the script (create-kubernetes-binaries-iso.sh) to create the latest CKS iso its fails with the following error

+ mkdir -p /tmp/iso//docker
++ /tmp/iso//k8s/kubeadm config images list --kubernetes-version=v1.31.1
/tmp/iso//k8s/kubeadm: line 1: syntax error near unexpected token `<'
/tmp/iso//k8s/kubeadm: line 1: `<?xml version='1.0' encoding='UTF-8'?><Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Details>No such object: kubernetes-release/release/v1.31.1/bin/linux/amd64/kubeadm</Details></Error>'

On investigating found that kubernetes community recommended to use "dl.k8s.io" instead of "storage.googleapis.com/kubernetes-release"

Blog post

https://kubernetes.io/blog/2023/06/09/dl-adopt-cdn/

CircleCI-Public/kubernetes-orb#74

kubernetes/kubernetes#127796

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

After making the change the cks iso got created successfully

+ curl -L --remote-name-all https://dl.k8s.io//release/v1.31.1/bin/linux/amd64/kubeadm https://dl.k8s.io//release/v1.31.1/bin/linux/amd64/kubelet https://dl.k8s.io//release/v1.31.1/bin/linux/amd64/kubectl
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138  100   138    0     0    383      0 --:--:-- --:--:-- --:--:--   383
100 55.5M  100 55.5M    0     0  18.2M      0  0:00:03  0:00:03 --:--:-- 22.3M
100   138  100   138    0     0    985      0 --:--:-- --:--:-- --:--:--   985
100 73.3M  100 73.3M    0     0  21.7M      0  0:00:03  0:00:03 --:--:-- 23.1M
100   138  100   138    0     0    985      0 --:--:-- --:--:-- --:--:--   985
100 53.7M  100 53.7M    0     0  5296k      0  0:00:10  0:00:10 --:--:-- 5070k
++ stat --format %a kubeadm

[DaanHoogland]

clgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (f652ad0) to head (a24ffa5).
Report is 12 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10295   +/-   ##
=========================================
  Coverage     15.14%   15.14%           
- Complexity    11282    11283    +1     
=========================================
  Files          5408     5408           
  Lines        473823   473823           
  Branches      57826    57826           
=========================================
+ Hits          71763    71772    +9     
+ Misses       394038   394026   -12     
- Partials       8022     8025    +3     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.87% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[weizhouapache]

code lgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12251

[DaanHoogland]

clgtm, tested the url out of bounds and works