Skip to content

Conversation

@vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Feb 10, 2025

Description

This PR fixes the missing buttons in the UI. This bug was introduced in #10243

Generated Summary

This pull request includes several changes to simplify the codebase by removing unnecessary braces in arrow functions across multiple configuration files. The changes ensure a more concise and consistent code style.

Codebase simplification:

Fixes: #10356

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@harikrishna-patnala
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (d920aba) to head (16740ff).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10357   +/-   ##
=========================================
  Coverage     15.15%   15.15%           
- Complexity    11317    11318    +1     
=========================================
  Files          5410     5410           
  Lines        474793   474778   -15     
  Branches      57928    57928           
=========================================
+ Hits          71955    71956    +1     
+ Misses       394789   394773   -16     
  Partials       8049     8049           
Flag Coverage Δ
uitests 4.29% <ø> (+<0.01%) ⬆️
unittests 15.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Feb 10, 2025
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10357 (QA-JID-547)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, looks good in qa as well

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishesh92 do we need it here too ?

image

@vishesh92
Copy link
Member Author

@vishesh92 do we need it here too ?

image

missed that. let me add.

@vishesh92
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10357 (QA-JID-548)

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@DaanHoogland DaanHoogland merged commit d3170bf into apache:4.19 Feb 10, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the fixup-missing-buttons branch February 10, 2025 11:15
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no 'add vpc', 'add vpn', 'add vpn customer gateway' buttons are shown

4 participants