-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Fix Apache CloudStack description on the onboarding page #10373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix Apache CloudStack description on the onboarding page #10373
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10373 +/- ##
============================================
- Coverage 15.15% 15.15% -0.01%
Complexity 11314 11314
============================================
Files 5413 5413
Lines 474670 474670
Branches 57890 57890
============================================
- Hits 71943 71937 -6
- Misses 394680 394687 +7
+ Partials 8047 8046 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
weizhouapache
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
Though I have no objection to the change, I wonder if premium versions are really still available. As far as I know the current developing companies contributeeverything they add to the open source version, so the premium bit would not make sense. |
|
@DaanHoogland yes, and IMHO, even if there were premium versions that don't push upstream, it would not be our responsibility, as an Apache project, to inform users about these premium versions. |
|
Ok, so as the release candidate for 4.19.2 is already out I propose to merge this as soon as it is voted on. for now it has no high priority. |
|
the RC is stopped with an issue. I think we can risk this one before the next RC |
…10373) * remove sentence from en.json * remove sentence from ar.json * remove sentence from ca.json * remove sentence from de_DE.json * remove sentence from el_GR.json * remove sentence from es.json * remove sentence from fr_FR.json * remove sentence from hu.json * remove sentence from it_IT.json * remove sentence from ko_KR.json * remove sentence from nb_NO.json * remove sentence from ja_JP.json * remove sentence from nl_NL.json * remove sentence from pl.json * remove sentence from pt_BR.json * remove sentence from ru_RU.json * remove sentence from zh_CN.json
Description
Currently, the Apache CloudStack description on the onboarding page states that:
This PR removes this outdated sentence.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity