Change L2 network offering form to not require a compute offering #10389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10389 +/- ##
=========================================
Coverage 16.07% 16.07%
- Complexity 13189 13191 +2
=========================================
Files 5664 5664
Lines 497599 497609 +10
Branches 60214 60216 +2
=========================================
+ Hits 79983 79993 +10
+ Misses 408666 408660 -6
- Partials 8950 8956 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Bernardo De Marco Gonçalves <[email protected]>
Member
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
bernardodemarco
approved these changes
Feb 18, 2025
Member
bernardodemarco
left a comment
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, tested in the QA environment
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
…ache#10389) * Change L2 offering form to not require a compute offering * apply bernado's suggestion Co-authored-by: Bernardo De Marco Gonçalves <[email protected]> --------- Co-authored-by: Lucas Martins <[email protected]> Co-authored-by: Bernardo De Marco Gonçalves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating a L2 network offering via UI, the compute offering parameter is required despite L2 networks not using a virtual router and the compute offering itself.
This PR removes the compute offering parameter from
Add Network Offeringform when L2 guest type is selected.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
As shown in the screenshot above, the compute offering option is no longer present when selecting L2 guest type. By selecting the Isolated and Shared types, I checked that the parameter still available.
I also created some network offerings of each type and everything is working as intended.