Skip to content

Conversation

@bernardodemarco
Copy link
Member

@bernardodemarco bernardodemarco commented Feb 13, 2025

Description

The docHelp property of the Add Hosts, Add Clusters, Disable Clusters and Enable Clusters UI forms references an incorrect documentation link, resulting in a 404 error when the user clicks the help button. This PR fixes these links.


Fixes #10390

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Verified that when the help button of the Add Hosts form is clicked, the Apache CloudStack UI redirects the user to the correct documentation section.
  • Verified that when the help button of the Add Clusters form is clicked, the Apache CloudStack UI redirects the user to the correct documentation section.
  • Verified that when the help button of the Disable Clusters form is clicked, the Apache CloudStack UI redirects the user to the correct documentation section.
  • Verified that when the help button of the Enable Clusters form is clicked, the Apache CloudStack UI redirects the user to the correct documentation section.

@bernardodemarco
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@bernardodemarco bernardodemarco added this to the 4.19.3 milestone Feb 13, 2025
@bernardodemarco bernardodemarco changed the title UI: Fix docHelp links for Add Hosts and Add Clusters forms UI: Fix docHelp links for Add Hosts, Add Clusters, Disable Clusters and Enable Clusters forms Feb 13, 2025
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (ae1d7cc) to head (f1d5f79).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10394      +/-   ##
============================================
- Coverage     15.15%   15.15%   -0.01%     
  Complexity    11314    11314              
============================================
  Files          5413     5413              
  Lines        474670   474670              
  Branches      57890    57890              
============================================
- Hits          71943    71936       -7     
- Misses       394680   394688       +8     
+ Partials       8047     8046       -1     
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10394 (QA-JID-553)

@DaanHoogland DaanHoogland linked an issue Feb 14, 2025 that may be closed by this pull request
Copy link
Collaborator

@lucas-a-martins lucas-a-martins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a local environment (QA is outdated) and every doc helper is now redirecting to the right page

@DaanHoogland
Copy link
Contributor

Tested in a local environment (QA is outdated) and every doc helper is now redirecting to the right page

qa should be based on 4.20.0 @lucas-a-martins . what are you missing?

@bernardodemarco
Copy link
Member Author

Tested in a local environment (QA is outdated) and every doc helper is now redirecting to the right page

qa should be based on 4.20.0 @lucas-a-martins . what are you missing?

@DaanHoogland, I think that what Lucas meant was that the UI QA env was built based on this commit 49baead. After it was built, I pushed another commit f1d5f79.

@DaanHoogland
Copy link
Contributor

Ok, the way backend is always based on the newest release (if someone thinks of updating it) the standard ui as well, only the ui only updates to the latest release can be tested in it.

@DaanHoogland DaanHoogland modified the milestones: 4.19.3, 4.19.2 Feb 17, 2025
@DaanHoogland DaanHoogland merged commit 212f2a3 into apache:4.19 Feb 17, 2025
26 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 Documentation page not found ( Add Cluster )

5 participants