-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Fix docHelp links for Add Hosts, Add Clusters, Disable Clusters and Enable Clusters forms
#10394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix docHelp links for Add Hosts, Add Clusters, Disable Clusters and Enable Clusters forms
#10394
Conversation
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
docHelp links for Add Hosts and Add Clusters formsdocHelp links for Add Hosts, Add Clusters, Disable Clusters and Enable Clusters forms
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10394 +/- ##
============================================
- Coverage 15.15% 15.15% -0.01%
Complexity 11314 11314
============================================
Files 5413 5413
Lines 474670 474670
Branches 57890 57890
============================================
- Hits 71943 71936 -7
- Misses 394680 394688 +8
+ Partials 8047 8046 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
lucas-a-martins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in a local environment (QA is outdated) and every doc helper is now redirecting to the right page
qa should be based on 4.20.0 @lucas-a-martins . what are you missing? |
@DaanHoogland, I think that what Lucas meant was that the UI QA env was built based on this commit 49baead. After it was built, I pushed another commit f1d5f79. |
|
Ok, the way backend is always based on the newest release (if someone thinks of updating it) the standard ui as well, only the ui only updates to the latest release can be tested in it. |
… and Enable Clusters forms (apache#10394)
Description
The
docHelpproperty of the Add Hosts, Add Clusters, Disable Clusters and Enable Clusters UI forms references an incorrect documentation link, resulting in a 404 error when the user clicks the help button. This PR fixes these links.Fixes #10390
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?