VMware import issue fix - check and update pools in the order of disks

[sureshanaparti]

Description

This PR checks and updates the pools in the order of disks (avoids update by position, which is the unit number in the disk controller [ide / scsi]).

Fixes #10404

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested VM (Default CentOS VM) import from VMware to KVM using NFS secondary storage.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 40.42553% with 28 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (212f2a3) to head (969c3f3).
Report is 1 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	27.02%	20 Missing and 7 partials ⚠️
...torage/volume/VolumeImportUnmanageManagerImpl.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10409      +/-   ##
============================================
- Coverage     15.15%   15.15%   -0.01%     
+ Complexity    11318    11313       -5     
============================================
  Files          5413     5413              
  Lines        474670   474662       -8     
  Branches      57890    57887       -3     
============================================
- Hits          71953    71929      -24     
- Misses       394668   394689      +21     
+ Partials       8049     8044       -5     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.87% <40.42%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[DaanHoogland]

@kiranchavala , can you check if this solves #10404 ?

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12488

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[harikrishna-patnala]

code LGTM

[blueorangutan]

[SF] Trillian test result (tid-12451)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47495 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10409-t12451-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[kiranchavala]

LGTM, Tested the vmware to kvm import

1. Without tags on compute offering and storage >> success
2. With tags on compute offering and storage >> success