ipmi: extra log sanitation #10428

DaanHoogland · 2025-02-19T11:51:35Z

Description

This PR fixes a logging of IPMI passwords

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

andrijapanicsb · 2025-02-19T11:55:16Z

This is a serious security issue for some people who are having audits with "no clear-text passwords in files on the server"

I kindly request @DaanHoogland that this goes into the next 4.19 release, ASAP.

Needs proper testing, and not CLGTM, please.

codecov · 2025-02-19T11:59:50Z

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (212f2a3) to head (9ba35a9).
Report is 4 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...andmanagement/driver/ipmitool/IpmitoolWrapper.java	0.00%	17 Missing ⚠️
...er/ipmitool/IpmitoolOutOfBandManagementDriver.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10428      +/-   ##
============================================
- Coverage     15.15%   15.15%   -0.01%     
+ Complexity    11318    11313       -5     
============================================
  Files          5413     5413              
  Lines        474670   474698      +28     
  Branches      57890    57891       +1     
============================================
- Hits          71953    71931      -22     
- Misses       394668   394724      +56     
+ Partials       8049     8043       -6

Flag	Coverage Δ
uitests	`4.29% <ø> (ø)`
unittests	`15.87% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kiranchavala · 2025-02-19T12:16:29Z

@blueorangutan package

blueorangutan · 2025-02-19T12:18:03Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland · 2025-02-19T12:21:45Z

This is a serious security issue for some people who are having audits with "no clear-text passwords in files on the server"

I kindly request @DaanHoogland that this goes into the next 4.19 release, ASAP.

Needs proper testing, and not CLGTM, please.

I am willing to wait a little longer but do not consider this high priority. If it needs extensive testing then that should be provided by whoever wants to hold the next RC for this.

blueorangutan · 2025-02-19T13:15:20Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12512

weizhouapache

code lgtm

kiranchavala

 LGTM , Tested using a docker image   
 
https://github.com/vapor-ware/ipmi-simulator     

Before the fix , you could find the password credential logged

2025-02-20 06:09:29,963 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ADMIN chassis power status] was successful and got the result [Chassis Power is on].

  2025-02-20 06:09:28,927 INFO  [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-39:ctx-2e0eb985 job-55) (logid:46f7e112) Add job-55 into job monitoring
2025-02-20 06:09:28,931 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-39:ctx-2e0eb985 job-55) (logid:5b7d3af5) Executing AsyncJobVO: {id:55, userId: 2, accountId: 2, instanceType: Host, instanceId: 1, cmd: org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd, cmdInfo: {"response":"json","ctxUserId":"2","sessionkey":"ISe69XMLJL-h-Gvz9Mg79vQmma8","action":"STATUS","hostid":"a11f4aca-2831-495e-9783-f821bb8e69a3","httpmethod":"GET","ctxStartEventId":"226","ctxDetails":"{\"interface com.cloud.host.Host\":\"a11f4aca-2831-495e-9783-f821bb8e69a3\"}","ctxAccountId":"2","cmdEventType":"HOST.OOBM.ACTION"}, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986607125160, completeMsid: null, lastUpdated: null, lastPolled: null, created: null, removed: null}
2025-02-20 06:09:28,947 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) Preparing command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status] to execute.
2025-02-20 06:09:28,948 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) Submitting command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status].
2025-02-20 06:09:28,948 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) Waiting for a response from command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status]. Defined timeout: [60].
2025-02-20 06:09:29,963 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) Process standard output for command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status]: [Chassis Power is on
2025-02-20 06:09:29,963 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) Process standard error output command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status]: [Unable to Get Channel Cipher Suites
2025-02-20 06:09:29,963 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ADMIN chassis power status] was successful and got the result [Chassis Power is on].
2025-02-20 06:09:29,971 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-39:ctx-2e0eb985 job-55 ctx-3599cec4) (logid:5b7d3af5) Complete async job-55, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.OutOfBandManagementResponse/outofbandmanagement/{"hostid":"a11f4aca-2831-495e-9783-f821bb8e69a3","powerstate":"On","enabled":"true","driver":"ipmitool","address":"localhost","port":"623","username":"ADMIN","password":"A*****","action":"STATUS","description":"Chassis Power is on

After fix , tested all the out of band actions and found that the password credentials is not getting logged   

Power action ON  

2025-02-20 05:50:09,894 INFO  [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-29:ctx-4c668953 job-35) (logid:2b3a78fd) Add job-35 into job monitoring
2025-02-20 05:50:09,898 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-29:ctx-4c668953 job-35) (logid:82334c43) Executing AsyncJobVO: {id:35, userId: 2, accountId: 2, instanceType: Host, instanceId: 1, cmd: org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd, cmdInfo: {"response":"json","ctxUserId":"2","sessionkey":"-AhVpUmfgI1zREvJdJphOb3jQ3k","action":"ON","hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","httpmethod":"GET","ctxStartEventId":"13111","ctxDetails":"{\"interface com.cloud.host.Host\":\"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4\"}","ctxAccountId":"2","cmdEventType":"HOST.OOBM.ACTION"}, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986556793223, completeMsid: null, lastUpdated: null, lastPolled: null, created: null, removed: null}
2025-02-20 05:50:09,976 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-29:ctx-4c668953 job-35 ctx-8b323360) (logid:82334c43) Preparing command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power on] to execute.
2025-02-20 05:50:09,978 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-29:ctx-4c668953 job-35 ctx-8b323360) (logid:82334c43) Submitting command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power on].
2025-02-20 05:50:09,978 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-29:ctx-4c668953 job-35 ctx-8b323360) (logid:82334c43) Waiting for a response from command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power on]. Defined timeout: [60].
2025-02-20 05:50:10,999 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-29:ctx-4c668953 job-35 ctx-8b323360) (logid:82334c43) Process standard output for command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power on]: [Chassis Power Control: Up/On
2025-02-20 05:50:11,000 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-29:ctx-4c668953 job-35 ctx-8b323360) (logid:82334c43) Process standard error output command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power on]: [Unable to Get Channel Cipher Suites
2025-02-20 05:50:11,000 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-29:ctx-4c668953 job-35 ctx-8b323360) (logid:82334c43) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p ****  -U ADMIN -P ****  chassis power on] was successful and got the result [Chassis Power Control: Up/On].
2025-02-20 05:50:11,008 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-29:ctx-4c668953 job-35 ctx-8b323360) (logid:82334c43) Complete async job-35, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.OutOfBandManagementResponse/outofbandmanagement/{"hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","powerstate":"On","enabled":"true","driver":"ipmitool","address":"localhost","port":"623","username":"ADMIN","password":"A*****","action":"ON","description":"Chassis Power Control: Up/On

Power action OFF 

2025-02-20 05:59:48,221 INFO  [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-30:ctx-5f9fa25a job-36) (logid:02983087) Add job-36 into job monitoring
2025-02-20 05:59:48,225 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-30:ctx-5f9fa25a job-36) (logid:9627ca0c) Executing AsyncJobVO: {id:36, userId: 2, accountId: 2, instanceType: Host, instanceId: 1, cmd: org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd, cmdInfo: {"response":"json","ctxUserId":"2","sessionkey":"-AhVpUmfgI1zREvJdJphOb3jQ3k","action":"OFF","hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","httpmethod":"GET","ctxStartEventId":"13114","ctxDetails":"{\"interface com.cloud.host.Host\":\"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4\"}","ctxAccountId":"2","cmdEventType":"HOST.OOBM.ACTION"}, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986556793223, completeMsid: null, lastUpdated: null, lastPolled: null, created: null, removed: null}
2025-02-20 05:59:48,245 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-30:ctx-5f9fa25a job-36 ctx-ef9355e1) (logid:9627ca0c) Preparing command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power off] to execute.
2025-02-20 05:59:48,246 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-30:ctx-5f9fa25a job-36 ctx-ef9355e1) (logid:9627ca0c) Submitting command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power off].
2025-02-20 05:59:48,246 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-30:ctx-5f9fa25a job-36 ctx-ef9355e1) (logid:9627ca0c) Waiting for a response from command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power off]. Defined timeout: [60].
2025-02-20 05:59:49,261 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-30:ctx-5f9fa25a job-36 ctx-ef9355e1) (logid:9627ca0c) Process standard output for command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power off]: [Chassis Power Control: Down/Off
2025-02-20 05:59:49,261 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-30:ctx-5f9fa25a job-36 ctx-ef9355e1) (logid:9627ca0c) Process standard error output command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power off]: [Unable to Get Channel Cipher Suites
2025-02-20 05:59:49,261 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-30:ctx-5f9fa25a job-36 ctx-ef9355e1) (logid:9627ca0c) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p ****  -U ADMIN -P ****  chassis power off] was successful and got the result [Chassis Power Control: Down/Off].
2025-02-20 05:59:49,270 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-30:ctx-5f9fa25a job-36 ctx-ef9355e1) (logid:9627ca0c) Complete async job-36, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.OutOfBandManagementResponse/outofbandmanagement/{"hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","powerstate":"On","enabled":"true","driver":"ipmitool","address":"localhost","port":"623","username":"ADMIN","password":"A*****","action":"OFF","description":"Chassis Power Control: Down/Off

Power action CYCLE

  2025-02-20 06:03:13,576 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-31:ctx-41a57274 job-37) (logid:7e1c0cd2) Executing AsyncJobVO: {id:37, userId: 2, accountId: 2, instanceType: Host, instanceId: 1, cmd: org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd, cmdInfo: {"response":"json","ctxUserId":"2","sessionkey":"-AhVpUmfgI1zREvJdJphOb3jQ3k","action":"CYCLE","hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","httpmethod":"GET","ctxStartEventId":"13117","ctxDetails":"{\"interface com.cloud.host.Host\":\"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4\"}","ctxAccountId":"2","cmdEventType":"HOST.OOBM.ACTION"}, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986556793223, completeMsid: null, lastUpdated: null, lastPolled: null, created: null, removed: null}
2025-02-20 06:03:13,591 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-31:ctx-41a57274 job-37 ctx-86765c9b) (logid:7e1c0cd2) Preparing command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power cycle] to execute.
2025-02-20 06:03:13,591 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-31:ctx-41a57274 job-37 ctx-86765c9b) (logid:7e1c0cd2) Submitting command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power cycle].
2025-02-20 06:03:13,591 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-31:ctx-41a57274 job-37 ctx-86765c9b) (logid:7e1c0cd2) Waiting for a response from command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power cycle]. Defined timeout: [60].
2025-02-20 06:03:14,608 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-31:ctx-41a57274 job-37 ctx-86765c9b) (logid:7e1c0cd2) Process standard output for command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power cycle]: [Chassis Power Control: Cycle
2025-02-20 06:03:14,608 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-31:ctx-41a57274 job-37 ctx-86765c9b) (logid:7e1c0cd2) Process standard error output command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power cycle]: [Unable to Get Channel Cipher Suites
2025-02-20 06:03:14,608 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-31:ctx-41a57274 job-37 ctx-86765c9b) (logid:7e1c0cd2) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p ****  -U ADMIN -P ****  chassis power cycle] was successful and got the result [Chassis Power Control: Cycle].
2025-02-20 06:03:14,616 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-31:ctx-41a57274 job-37 ctx-86765c9b) (logid:7e1c0cd2) Complete async job-37, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.OutOfBandManagementResponse/outofbandmanagement/{"hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","powerstate":"Off","enabled":"true","driver":"ipmitool","address":"localhost","port":"623","username":"ADMIN","password":"A*****","action":"CYCLE","description":"Chassis Power Control: Cycle

Power action RESET

  2025-02-20 06:04:17,970 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-32:ctx-d4ed6014 job-38) (logid:219cc3e0) Executing AsyncJobVO: {id:38, userId: 2, accountId: 2, instanceType: Host, instanceId: 1, cmd: org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd, cmdInfo: {"response":"json","ctxUserId":"2","sessionkey":"-AhVpUmfgI1zREvJdJphOb3jQ3k","action":"RESET","hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","httpmethod":"GET","ctxStartEventId":"13120","ctxDetails":"{\"interface com.cloud.host.Host\":\"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4\"}","ctxAccountId":"2","cmdEventType":"HOST.OOBM.ACTION"}, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986556793223, completeMsid: null, lastUpdated: null, lastPolled: null, created: null, removed: null}
2025-02-20 06:04:17,986 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-32:ctx-d4ed6014 job-38 ctx-91f59f11) (logid:219cc3e0) Preparing command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power reset] to execute.
2025-02-20 06:04:17,987 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-32:ctx-d4ed6014 job-38 ctx-91f59f11) (logid:219cc3e0) Submitting command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power reset].
2025-02-20 06:04:17,987 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-32:ctx-d4ed6014 job-38 ctx-91f59f11) (logid:219cc3e0) Waiting for a response from command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power reset]. Defined timeout: [60].
2025-02-20 06:04:19,002 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-32:ctx-d4ed6014 job-38 ctx-91f59f11) (logid:219cc3e0) Process standard output for command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power reset]: [Chassis Power Control: Reset
2025-02-20 06:04:19,002 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-32:ctx-d4ed6014 job-38 ctx-91f59f11) (logid:219cc3e0) Process standard error output command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power reset]: [Unable to Get Channel Cipher Suites
2025-02-20 06:04:19,002 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-32:ctx-d4ed6014 job-38 ctx-91f59f11) (logid:219cc3e0) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p ****  -U ADMIN -P ****  chassis power reset] was successful and got the result [Chassis Power Control: Reset].
2025-02-20 06:04:19,009 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-32:ctx-d4ed6014 job-38 ctx-91f59f11) (logid:219cc3e0) Complete async job-38, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.OutOfBandManagementResponse/outofbandmanagement/{"hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","powerstate":"On","enabled":"true","driver":"ipmitool","address":"localhost","port":"623","username":"ADMIN","password":"A*****","action":"RESET","description":"Chassis Power Control: Reset

Power action STATUS  

2025-02-20 05:29:32,975 INFO  [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-28:ctx-b1b41c80 job-34) (logid:0a57d347) Add job-34 into job monitoring
2025-02-20 05:29:32,980 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-28:ctx-b1b41c80 job-34) (logid:3eee3c40) Executing AsyncJobVO: {id:34, userId: 2, accountId: 2, instanceType: Host, instanceId: 1, cmd: org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd, cmdInfo: {"response":"json","ctxUserId":"2","sessionkey":"-AhVpUmfgI1zREvJdJphOb3jQ3k","action":"STATUS","hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","httpmethod":"GET","ctxStartEventId":"13108","ctxDetails":"{\"interface com.cloud.host.Host\":\"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4\"}","ctxAccountId":"2","cmdEventType":"HOST.OOBM.ACTION"}, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986556793223, completeMsid: null, lastUpdated: null, lastPolled: null, created: null, removed: null}
2025-02-20 05:29:33,002 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-28:ctx-b1b41c80 job-34 ctx-c30257bb) (logid:3eee3c40) Preparing command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status] to execute.
2025-02-20 05:29:33,003 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-28:ctx-b1b41c80 job-34 ctx-c30257bb) (logid:3eee3c40) Submitting command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status].
2025-02-20 05:29:33,003 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-28:ctx-b1b41c80 job-34 ctx-c30257bb) (logid:3eee3c40) Waiting for a response from command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status]. Defined timeout: [60].
2025-02-20 05:29:34,018 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-28:ctx-b1b41c80 job-34 ctx-c30257bb) (logid:3eee3c40) Process standard output for command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status]: [Chassis Power is on
2025-02-20 05:29:34,018 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-28:ctx-b1b41c80 job-34 ctx-c30257bb) (logid:3eee3c40) Process standard error output command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power status]: [Unable to Get Channel Cipher Suites
2025-02-20 05:29:34,018 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-28:ctx-b1b41c80 job-34 ctx-c30257bb) (logid:3eee3c40) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p ****  -U ADMIN -P ****  chassis power status] was successful and got the result [Chassis Power is on]
2025-02-20 05:29:34,031 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-28:ctx-b1b41c80 job-34 ctx-c30257bb) (logid:3eee3c40) Complete async job-34, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.OutOfBandManagementResponse/outofbandmanagement/{"hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","powerstate":"On","enabled":"true","driver":"ipmitool","address":"localhost","port":"623","username":"ADMIN","password":"A*****","action":"STATUS","description":"Chassis Power is on

Power action SOFT   

2025-02-20 06:05:16,323 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-33:ctx-217c5f3d job-39) (logid:03cf5b3b) Executing AsyncJobVO: {id:39, userId: 2, accountId: 2, instanceType: Host, instanceId: 1, cmd: org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd, cmdInfo: {"response":"json","ctxUserId":"2","sessionkey":"-AhVpUmfgI1zREvJdJphOb3jQ3k","action":"SOFT","hostid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4","httpmethod":"GET","ctxStartEventId":"13123","ctxDetails":"{\"interface com.cloud.host.Host\":\"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4\"}","ctxAccountId":"2","cmdEventType":"HOST.OOBM.ACTION"}, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986556793223, completeMsid: null, lastUpdated: null, lastPolled: null, created: null, removed: null}
2025-02-20 06:05:16,341 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-33:ctx-217c5f3d job-39 ctx-0ae78364) (logid:03cf5b3b) Preparing command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power soft] to execute.
2025-02-20 06:05:16,342 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-33:ctx-217c5f3d job-39 ctx-0ae78364) (logid:03cf5b3b) Submitting command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power soft].
2025-02-20 06:05:16,342 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-33:ctx-217c5f3d job-39 ctx-0ae78364) (logid:03cf5b3b) Waiting for a response from command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power soft]. Defined timeout: [60].
2025-02-20 06:05:17,357 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-33:ctx-217c5f3d job-39 ctx-0ae78364) (logid:03cf5b3b) Process standard output for command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power soft]: [].
2025-02-20 06:05:17,357 DEBUG [o.a.c.u.p.ProcessRunner] (API-Job-Executor-33:ctx-217c5f3d job-39 ctx-0ae78364) (logid:03cf5b3b) Process standard error output command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p 623 -U ADMIN -P ***** chassis power soft]: [Unable to Get Channel Cipher Suites
2025-02-20 06:05:17,357 DEBUG [o.a.c.o.d.i.IpmitoolOutOfBandManagementDriver] (API-Job-Executor-33:ctx-217c5f3d job-39 ctx-0ae78364) (logid:03cf5b3b) The command [/usr/bin/ipmitool -I lanplus -R 1 -v -H localhost -p ****  -U ADMIN -P ****  chassis power soft] failed and got the result []. Error: [Unable to Get Channel Cipher Suites
2025-02-20 06:05:17,358 DEBUG [o.a.c.o.OutOfBandManagementServiceImpl] (API-Job-Executor-33:ctx-217c5f3d job-39 ctx-0ae78364) (logid:03cf5b3b) Out-of-band Management action [SOFT] on Host {"id":1,"name":"ol8.localdomain","type":"Routing","uuid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4"} failed with error: Unable to Get Channel Cipher Suites
2025-02-20 06:05:17,364 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-33:ctx-217c5f3d job-39) (logid:03cf5b3b) Unexpected exception while executing org.apache.cloudstack.api.command.admin.outofbandmanagement.IssueOutOfBandManagementPowerActionCmd
2025-02-20 06:05:17,366 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-33:ctx-217c5f3d job-39) (logid:03cf5b3b) Complete async job-39, jobStatus: FAILED, resultCode: 530, result: org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":"530","errortext":"Out-of-band Management action [SOFT] on Host {"id":1,"name":"ol8.localdomain","type":"Routing","uuid":"765fc8ea-90b6-41ff-88d4-2f96fa4d27a4"} failed with error: Unable to Get Channel Cipher Suites

extra sanitation

9ba35a9

DaanHoogland requested review from andrijapanicsb and kiranchavala February 19, 2025 11:51

andrijapanicsb added this to the 4.19.2 milestone Feb 19, 2025

weizhouapache approved these changes Feb 19, 2025

View reviewed changes

kiranchavala approved these changes Feb 20, 2025

View reviewed changes

weizhouapache changed the title ~~extra sanitation~~ ipmi: extra log sanitation Feb 20, 2025

DaanHoogland merged commit e196275 into apache:4.19 Feb 20, 2025
23 of 25 checks passed

DaanHoogland deleted the ipmi-log-sanatise branch February 20, 2025 08:01

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

ipmi: extra log sanitation (apache#10428)

5e44c34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ipmi: extra log sanitation #10428

ipmi: extra log sanitation #10428

Uh oh!

DaanHoogland commented Feb 19, 2025

Uh oh!

andrijapanicsb commented Feb 19, 2025

Uh oh!

codecov bot commented Feb 19, 2025 •

edited

Loading

Uh oh!

kiranchavala commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

DaanHoogland commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

weizhouapache left a comment

Uh oh!

kiranchavala left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ipmi: extra log sanitation #10428

ipmi: extra log sanitation #10428

Uh oh!

Conversation

DaanHoogland commented Feb 19, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

andrijapanicsb commented Feb 19, 2025

Uh oh!

codecov bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kiranchavala commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

DaanHoogland commented Feb 19, 2025

Uh oh!

blueorangutan commented Feb 19, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Feb 19, 2025 •

edited

Loading