server: fetch IP of VMs on L2 networks

[weizhouapache]

Description

This PR fixes an issue with #10376 , and adds the support to get vm IP for VMs on L2 network via qemu-guest-agent

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (f50de89) to head (cf8f2fc).
Report is 53 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	8 Missing ⚠️
...e/wrapper/LibvirtGetVmIpAddressCommandWrapper.java	82.85%	2 Missing and 4 partials ⚠️
...ava/com/cloud/agent/api/GetVmIpAddressCommand.java	40.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10431   +/-   ##
=========================================
  Coverage     15.16%   15.17%           
- Complexity    11329    11331    +2     
=========================================
  Files          5413     5413           
  Lines        474782   474811   +29     
  Branches      57903    57907    +4     
=========================================
+ Hits          72010    72032   +22     
- Misses       394722   394725    +3     
- Partials       8050     8054    +4     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.89% <64.58%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12514

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12515

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12475)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46169 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10431-t12475-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[Pearl1594]

@weizhouapache can you please check if this PR does the same as what #10376 is doing?

[weizhouapache]

@weizhouapache can you please check if this PR does the same as what #10376 is doing?

As suggested by @NuxRo , I cherry-picked 10376 into this PR so we can test together.

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12635

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12638

[NuxRo]

Looking good so far @weizhouapache !

[weizhouapache]

Looking good so far @weizhouapache !

thanks for the testing @NuxRo !

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12817

[NuxRo]

lgtm

[DaanHoogland]

clgtm

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13309

[DaanHoogland]

(btw merged because @NuxRo stated that he meant he tested it in #10431 (review) , so its his fault)